Bugzilla – Full Text Bug Listing
| Summary: | Validator test failures in the build | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Curtis Windatt <curtis.windatt.public> |
| Component: | JS Tools | Assignee: | Olivier Thomann <Olivier_Thomann> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 10.0 | ||
| Target Milestone: | 11.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| See Also: |
https://git.eclipse.org/r/62962 https://git.eclipse.org/r/62963 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5b6830a9626e3790b4df46b433d70fdbce255c9d |
||
| Whiteboard: | |||
Different browsers can return different errors for invalid regular expression. We should not include the browser's error as part of the expected message. A patch will follow shortly. New Gerrit change created: https://git.eclipse.org/r/62962 (In reply to Olivier Thomann from comment #1) > Different browsers can return different errors for invalid regular > expression. We should not include the browser's error as part of the > expected message. > A patch will follow shortly. I disagree. The browsers message has useful information on what is wrong with the regular expression. The tests should be modified to not care about the exact wording of the message. New Gerrit change created: https://git.eclipse.org/r/62963 I agree. We should report the browser's error message, but not rely on it to pass the tests. I added a check to make sure we report the error on the Regex node. See the new change in gerrit. Gerrit change https://git.eclipse.org/r/62963 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5b6830a9626e3790b4df46b433d70fdbce255c9d http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5b6830a9626e3790b4df46b433d70fdbce255c9d Applied the fix to master. Will close when tests pass in the build Build successful, no test failures. |
6 tests failed. FAILED: TEST_http___orion_test_mybluemix_net_80_js_tests_javascript_JsMochaSuite_html_env_integration_29cf34419da04547bb719c14c503ceff.xml.SuiteFailure Error Message: Test exceeded maximum duration after 120 seconds Stack Trace: Error: Test exceeded maximum duration after 120 seconds at throwError (/home/vcap/app/Gruntfile.js:218:60) at writeXUnitReport (/home/vcap/app/Gruntfile.js:229:4) at _fulfilled (/home/vcap/app/node_modules/q/q.js:794:54) at self.promiseDispatch.done (/home/vcap/app/node_modules/q/q.js:823:30) at Promise.promise.promiseDispatch (/home/vcap/app/node_modules/q/q.js:756:13) at /home/vcap/app/node_modules/q/q.js:817:14 at flush (/home/vcap/app/node_modules/q/q.js:110:17) at process._tickCallback (node.js:448:13) FAILED: Windows_7_internet_explorer_11.js_tests_core_coreTests.config on plugin load early registration.should have correct updated() call ordering Error Message: timeout of 20000ms exceeded Stack Trace: undefined FAILED: Windows_7_internet_explorer_11.js_tests_javascript_JsMochaSuite.Validator Tests ESLint Rule Tests no-invalid-regexp.flag invalid regexp Error Message: Wrong problem message: expected 'Expected \']\' in regular expression' to equal 'Invalid regular expression: /[/: Unterminated character class' Stack Trace: AssertionError: Wrong problem message: expected 'Expected \']\' in regular expression' to equal 'Invalid regular expression: /[/: Unterminated character class' at Assertion.prototype.assert (http://orion-test.mybluemix.net/chai/chai.js:914:7) at assert.equal (http://orion-test.mybluemix.net/chai/chai.js:2334:5) at assertProblems (http://orion-test.mybluemix.net/js-tests/javascript/validatorTests.js:98:8) at Anonymous function (http://orion-test.mybluemix.net/js-tests/javascript/validatorTests.js:10641:10) at settleDeferred (http://orion-test.mybluemix.net/orion/Deferred.js:70:7) at notify (http://orion-test.mybluemix.net/orion/Deferred.js:144:18) at run (http://orion-test.mybluemix.net/orion/Deferred.js:28:13) FAILED: Windows_7_internet_explorer_11.js_tests_javascript_JsMochaSuite.Validator Tests ESLint Rule Tests no-invalid-regexp.flag invalid regexp - new RegExp Error Message: Wrong problem message: expected 'Syntax error in regular expression' to equal 'Invalid regular expression: /\\/: \\ at end of pattern' Stack Trace: AssertionError: Wrong problem message: expected 'Syntax error in regular expression' to equal 'Invalid regular expression: /\\/: \\ at end of pattern' at Assertion.prototype.assert (http://orion-test.mybluemix.net/chai/chai.js:914:7) at assert.equal (http://orion-test.mybluemix.net/chai/chai.js:2334:5) at assertProblems (http://orion-test.mybluemix.net/js-tests/javascript/validatorTests.js:98:8) at Anonymous function (http://orion-test.mybluemix.net/js-tests/javascript/validatorTests.js:10675:10) at settleDeferred (http://orion-test.mybluemix.net/orion/Deferred.js:70:7) at notify (http://orion-test.mybluemix.net/orion/Deferred.js:144:18) at run (http://orion-test.mybluemix.net/orion/Deferred.js:28:13) FAILED: linux_firefox_38.js_tests_javascript_JsMochaSuite.Validator Tests ESLint Rule Tests no-invalid-regexp.flag invalid regexp Error Message: Wrong problem message: expected 'unterminated character class' to equal 'Invalid regular expression: /[/: Unterminated character class' Stack Trace: FAILED: linux_firefox_38.js_tests_javascript_JsMochaSuite.Validator Tests ESLint Rule Tests no-invalid-regexp.flag invalid regexp - new RegExp Error Message: Wrong problem message: expected '\\ at end of pattern' to equal 'Invalid regular expression: /\\/: \\ at end of pattern'