Bug 484591

Description Peter Cigehn 2015-12-17 10:44:06 EST

Created attachment 258767 [details]
Screen shot showing the superfluous warning dialog

Earlier it was introduced an explicit check of the multiplicity for capsule part, see discussion in Bug 473064 for example and an explicit dialog pops up in case a user enters an invalid multiplicity. The existence of this dialog was discussed already then, as indicated by Bug 473064 Comment 29.

Since a new constraint was added to the UML-RT profile, as part of Bug 483935, which checks that the multiplicity, the explicity checking for this in the UI/tooling is superfluous.

Apart from that, the tooling should really be updated to ensure that the user only can enter the upper bound part, which is related to introducing the field "Replication", see Bug 479350, which basically should prohibit the user from altering the lower bound of multiplicity.

Steps to reproduce:

1) Create a new UML-RT model
2) Create Capsule1 and Capsule2
3) Drag-and-drop Capsule2 onto Capsule1 to create capsule2 part
4) Select capsule2 part
5) In the properties on the Real Time tab view write "2..5" in the current multiplicity field (as long as Bug 479350 have not been fixed yet).
6) A dialog pops up stating "This multiplicity is not allowed for Capsule Part!" and the multiplicity is left unchanged in the model. Confusingly enough, the properties view is not refreshed so the text 2..5 is still shown in the properties view, so you have to switch to another element and back again to refresh the properties view and see that multiplicity has remained as before. But that is separate refresh issue.
7) Now switch editors using the switch button to the left of the multiplicity field so that you get separate editors for lower and upper bound (this shall also be removed within the scope of Bug 479350).
8) Now use the pen (edit) button to edit the value of lower bound to 2 and use the pen (edit) button to edit the value of upper bound to 5.  As can be seen, the superfluous check does not check all cases anyway, which makes is rather redundant.
9) Now validate the model
10) A problem appears in the Model Validation view, indicating "Fixed capsule parts cannot have variable multiplicity" which is the new constraint added by Bug 483935, which detects the invalid multiplicity.

Since we now have the constraint there should not be any need to have this superfluous check in the UI/tooling, especially considering that it does not detect the invalid multiplicity when editing the way shown in the steps to reproduce.