Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 484195

Summary: NPE on VSP rename
Product: [Modeling] Sirius Reporter: Esteban DUGUEPEROUX <esteban.dugueperoux>
Component: CoreAssignee: Project inbox <sirius.core-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: florian.barbin, pierre-charles.david
Version: 3.1.0Keywords: triaged
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Esteban DUGUEPEROUX CLA 2015-12-11 06:40:45 EST
I get the following NPE when renaming a Viewpoint Specification Project whose odesign is opened on Eclipse Mars:

Caused by: java.lang.NullPointerException
	at org.eclipse.ui.part.MultiPageEditorPart.deactivateSite(MultiPageEditorPart.java:947)
	at org.eclipse.ui.part.MultiPageEditorPart.dispose(MultiPageEditorPart.java:514)
	at org.eclipse.sirius.editor.editorPlugin.SiriusEditor.dispose(SiriusEditor.java:1320)
	at org.eclipse.sirius.editor.tools.internal.presentation.CustomSiriusEditor.dispose(CustomSiriusEditor.java:384)
	at org.eclipse.sirius.editor.editorPlugin.SiriusEditor$3$1.run(SiriusEditor.java:410)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)

Steps to reproduce :
1. Create a VSP
2. Rename it => KO
Comment 1 Esteban DUGUEPEROUX CLA 2016-01-06 11:12:33 EST
In EMF generated editor, there is no call to dispose() in second asyncExec of XXXEditor.resourceChangeListener. This has been explicitely added in SiriusEditor because calling getSite().getPage().closeEditor(SiriusEditor.this, false); doesn't call dispose method.
Comment 2 Pierre-Charles David CLA 2021-06-06 12:59:22 EDT

*** This bug has been marked as a duplicate of bug 517999 ***