Bugzilla – Full Text Bug Listing
| Summary: | Display advanced search option on a single line (and move checks to be in front of text) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Steve Northover <steve_northover> | ||||
| Component: | Client | Assignee: | Steve Northover <steve_northover> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | libingw, Silenio_Quarti | ||||
| Version: | 10.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: |
https://git.eclipse.org/r/62263 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=11b204bd68fd3af404a4331ee0a7bf4731a6ac91 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/search/InlineSearchPane.html b/bundles/org.eclipse.orion.client.ui/web/orion/search/InlineSearchPane.html index 394ba29..0c3b9e7 100644 --- a/bundles/org.eclipse.orion.client.ui/web/orion/search/InlineSearchPane.html +++ b/bundles/org.eclipse.orion.client.ui/web/orion/search/InlineSearchPane.html @@ -8,18 +8,18 @@ </div> <div class="searchParamBlockDiv"> <div class="searchOptionBlock"> - <div class="searchOption"> - <label id="advSearchCaseSensitiveLabel" class="searchCheckboxLabel" for="advSearchCaseSensitive"></label> + <span class="searchOption"> <input type="checkbox" id="advSearchCaseSensitive" class="searchCheckbox"> - </div> - <div class="searchOption"> - <label id="advSearchWholeWordLabel" class="searchCheckboxLabel" for="advSearchWholeWord"></label> + <label id="advSearchCaseSensitiveLabel" class="searchCheckboxLabel" for="advSearchCaseSensitive"></label> + </span> + <span class="searchOption"> <input type="checkbox" id="advSearchWholeWord" class="searchCheckbox"> - </div> - <div class="searchOption"> - <label id="advSearchRegExLabel" class="searchCheckboxLabel" for="advSearchRegEx"></label> + <label id="advSearchWholeWordLabel" class="searchCheckboxLabel" for="advSearchWholeWord"></label> + </span> + <span class="searchOption"> <input type="checkbox" id="advSearchRegEx" class="searchCheckbox"> - </div> + <label id="advSearchRegExLabel" class="searchCheckboxLabel" for="advSearchRegEx"></label> + </span> </div> <div class="searchOptionBlock"> <div class="searchOption"> Created attachment 258517 [details]
This patch file should be better than a patch in the comment
(In reply to Steve Northover from comment #2) > Created attachment 258517 [details] > This patch file should be better than a patch in the comment I am using self hosting. Can't apply the patch from within Orion. Strange. The patch looks good to me. New Gerrit change created: https://git.eclipse.org/r/62263 Gerrit change https://git.eclipse.org/r/62263 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=11b204bd68fd3af404a4331ee0a7bf4731a6ac91 pushed to master. |
The advanced search boxes ("Case sensitive", "Whole Word", "Regular Expression") are displayed in a column taking up space that could be used as search results. Let's display them in a row.