Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 483903

Summary:	Using 'Enter' to close the Generate Getters and Setters dialog (de)selects current focused field.
Product:	[Eclipse Project] Platform	Reporter:	Sofie Struyve <sofie.struyve>
Component:	SWT	Assignee:	Platform-SWT-Inbox <platform-swt-inbox>
Status:	CLOSED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, ericwill, gautier.desaintmartinlacaze, gj.schouten
Version:	4.6	Keywords:	triaged
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Sofie Struyve

2015-12-08 08:36:15 EST

Comment 1 Sofie Struyve

2015-12-08 08:38:13 EST

In the 'Generate Getters and Setters' dialog I use the keyboard to select the fields (and space to toggle the selection).
When I press enter to actually generate the getters and setters and close the dialog, the currently selected field gets deselected, and no getter/setter is created for that field.

Comment 2 Sofie Struyve

2015-12-08 08:42:58 EST

Works as expected with Luna 4.4.1 Build id: 20140925-1800)
Fails as described below with Mars 4.5.1 Build id: 20150924-1200

Comment 3 Sofie Struyve

2016-11-27 12:51:11 EST

The problem still exists in 4.6.1. and bugs me more and more.

The "Generate Getters and Setters" dialog isn't the only dialog suffering this behaviour. 
I believe the cause (and solution) for this problem should be found in the org.eclipse.ui.dialogs.CheckedTreeSelectionDialog or above. 
That's why I moved this bug from 'JDT' to 'platform'.

Comment 4 Dani Megert

2017-04-20 12:30:10 EDT

Can you try with http://download.eclipse.org/eclipse/downloads/drops4/I20170419-2000/ ?

I can't reproduce this with this build on my Windows 7 machine. Could be an OS specific issue though. Please provide the details of your OS and window manager.

Comment 5 Sofie Struyve

2017-04-21 02:13:11 EDT

@Dani Megert,

The problem still exists with the build you sent.
I use a vanilla Ubuntu (16.04) Linux with unity.
(When I raised the bug back in 2015, I was using ubuntu 12.04 with unity)

I asked a windows 8 colleague and he can not reproduce the problem with Neon 3 (4.6.3).
So it seems to be an OS specific problem indeed.

Comment 6 Dani Megert

2017-04-21 03:03:27 EDT

(In reply to Sofie Struyve from comment #5)
> @Dani Megert,
> 
> The problem still exists with the build you sent.
> I use a vanilla Ubuntu (16.04) Linux with unity.
> (When I raised the bug back in 2015, I was using ubuntu 12.04 with unity)
> 
> I asked a windows 8 colleague and he can not reproduce the problem with Neon
> 3 (4.6.3).
> So it seems to be an OS specific problem indeed.

Thanks for testing.

Comment 7 Sofie Struyve

2018-09-11 06:12:29 EDT

Tested it today on Photon (4.8.0 Build ID 20180619-1200); Still no luck.

Comment 8 Eric Williams

2019-02-20 14:30:37 EST

I cannot reproduce this issue on GTK3.24, SWT from master as of today, and Fedora 29. Maybe it was a unity specific bug?

Either way, closing it. Please reopen the ticket if the bug persists on GNOME with a recent GTK3 (3.22 or newer).