Bugzilla – Full Text Bug Listing
| Summary: | [content assist] Disable and remove substring completion from Preferences | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Noopur Gupta <noopur_gupta> |
| Component: | Text | Assignee: | Noopur Gupta <noopur_gupta> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, jarthana, marcel.bruch, markus.kell.r, noopur_gupta, sewe |
| Version: | 4.6 | ||
| Target Milestone: | 4.6 M4 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/62195 https://git.eclipse.org/r/62196 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=72e462e9ef7843806c83c04a17ed2dd34dcc7c52 https://git.eclipse.org/r/64126 |
||
| Whiteboard: | |||
|
Description
Noopur Gupta
New Gerrit change created: https://git.eclipse.org/r/62195 New Gerrit change created: https://git.eclipse.org/r/62196 A question - what should we do about the JavaCore option? It says "enabled" by default. (In reply to Jay Arthanareeswaran from comment #3) > A question - what should we do about the JavaCore option? It says "enabled" > by default. It was being used in JDT/UI while creating the preference option. I have commented that code. It was also being used in: AbstractJavaCompletionProposal.isSubstringMatching() to filter the proposals. I have commented the code in JDT/UI that calls this method. So now it is not used anywhere else. Do you still prefer to set it to "disabled"? (In reply to Noopur Gupta from comment #4) > So now it is not used anywhere else. Do you still prefer to set it to > "disabled"? I was not sure. Anyway, technically, we are removing the feature temporarily, which means the options is just a dummy one for the time being. I guess it can remain. If everyone agrees, I will release this patch. (In reply to Noopur Gupta from comment #4) > (In reply to Jay Arthanareeswaran from comment #3) > > A question - what should we do about the JavaCore option? It says "enabled" > > by default. > So now it is not used anywhere else. Do you still prefer to set it to > "disabled"? Updated the jdt.core Gerrit request after setting it to "disabled". I am not feeling strongly one way or other. In the interest of time, I have released the first patch set as I can't kick off the hudson job: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=2fa23e66e5b21c24ea6156b40678310e292047c8 Gerrit change https://git.eclipse.org/r/62196 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=72e462e9ef7843806c83c04a17ed2dd34dcc7c52 Is there a low level .options or something similar that would allow us (Code Recommenders) to test this already, to assess compatibility with our own Subwords matching? (In reply to Andreas Sewe from comment #9) > Is there a low level .options or something similar that would allow us (Code > Recommenders) to test this already, to assess compatibility with our own > Subwords matching? Unfortunately no. You will have to make code changes to enable the option. Verified for 4.6 M4 with build I20151209-2300. New Gerrit change created: https://git.eclipse.org/r/64126 (In reply to Eclipse Genie from comment #12) > New Gerrit change created: https://git.eclipse.org/r/64126 This revert commit has been pushed to master, so the substring completion prefs are there again in 4.6 M5. |