Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 483891

Summary: Operation filter for content relevancy
Product: [Tools] GEF Reporter: Frank Benoit <frank.rene.benoit>
Component: GEF MVCAssignee: gef-inbox <gef-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: matthias.wienand, nyssen
Version: unspecified   
Target Milestone: 4.0.0 / 3.11.0 (Neon) M5   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Comment 1 Alexander Nyßen CLA 2015-12-29 11:47:10 EST
We may realize this by extending ITransactionalOperation to indicate whether the transaction is content related. The editor may then filter its dirty state based on the respective indication.
Comment 2 Matthias Wienand CLA 2016-01-25 12:39:30 EST
I added the method ITransactionalOperation#isContentRelevant():boolean that determines if the operation is changing model data. The method is evaluated within AbstractFXEditor to decide whether or not the dirty flag of the editor is set when an operation is executed. The operations for adding/removing of content children, changing the content model, and attaching/detaching of content anchorages are content relevant, among with the specific operations within the Logo example. The rest of the operations are not content relevant. The code is published on the master branch, therefore, I resolve this ticket as fixed for 3.11.0M5.