Bugzilla – Full Text Bug Listing
| Summary: | [eslint] Investigate removing Orion-specific changes in ESLint | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Michael Rennie <Michael_Rennie> |
| Component: | JS Tools | Assignee: | Olivier Thomann <Olivier_Thomann> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Olivier_Thomann |
| Version: | 11.0 | ||
| Target Milestone: | 11.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/62420 https://git.eclipse.org/r/62423 https://git.eclipse.org/r/62424 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c48f2eac25f45e245dc864bd7e58bead36a0d97b |
||
| Whiteboard: | |||
|
Description
Michael Rennie
Right now I limited my changes to eslint.js to the report function. Orion adds a new parameter (related) and this needs to be properly handled. Once I am done, we can discuss the best way to work around these modifications. With that changes, all tests are green except the eslintRuleTests. They need to be reworked as they pass a text directly to the eslint tool. I think we might need to use a validator and go through the ternWorker. Michael, what do you think? (In reply to Olivier Thomann from comment #1) > With that changes, all tests are green except the eslintRuleTests. They need > to be reworked as they pass a text directly to the eslint tool. I think we > might need to use a validator and go through the ternWorker. Michael, what > do you think? That makes the most sense to me. That way all of the rules are tested how they are actually used (via the validator API) New Gerrit change created: https://git.eclipse.org/r/62420 New Gerrit change created: https://git.eclipse.org/r/62423 New Gerrit change created: https://git.eclipse.org/r/62424 Gerrit change https://git.eclipse.org/r/62424 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c48f2eac25f45e245dc864bd7e58bead36a0d97b Merged. |