Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 483500

Summary:	[jsdoc] Improve JSDoc completions after move to Tern plugin
Product:	[ECD] Orion	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	JS Tools	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie
Version:	10.0
Target Milestone:	11.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Curtis Windatt

2015-12-02 12:28:10 EST

I will add a test to demonstrate each case

1) Can't complete param name when period in type name
2) No type completion proposals when no closing curly brace
3) Keyword proposals showing up in type completions
4) Bad offsets in @param template proposal

Comment 1 Curtis Windatt

2015-12-02 18:09:31 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=52ea68047c39d9af1b4cc9f14b53f625e3122939
Fixed in master with tests

a) Regex for params didn't accept punctuation like .
b) Changed how we get local scope, before we look at preceding node and assume there is a scope there.  Now we walk the parents array looking for the smallest enclosing node with a scope (defaulting to the file scope).
c) In tern assist when creating template proposals we use the prefix argument coming from the template generator.  The template generator excludes punctuation like @.  This produced the bad offset.  Fix is to use the prefix from the proposal itself if available (default to the template generator argument).