Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 483403

Summary:	[tern] Use gather() API and remove need to check for object-ness in getFile callback
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	11.0
Target Milestone:	11.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Michael Rennie

2015-12-01 13:10:50 EST

We have a couple of hacks we should get rid of before updating to the latest version of Tern:

1. we have a hack to maintain a server.passes callback while computing completions - this should use the gather() API

2. we have a check in case an object is passed back as text from the getFile callback. This should be fixed in the client to never pass an object.

Comment 1 Michael Rennie

2015-12-01 15:47:09 EST

Fixed in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a702fb263af5f4ebb27bc2c0b19117f3a2209da5

I also made some additional changes:

1. sorted keyword proposals to the end of the listing, since they are mostly not relevant

2. ensured that the 'guess' state is properly passed through to open decl and open impl