Bug 483217

Comment 1 David Williams 2015-11-28 13:00:45 EST

I suggest until fixed, the shared launch config should be removed, since it is always a little concerning (and wasteful) to see "BUILD FAILED" fly by  console when I check out the project, or so something that causes it to be "rebuilt". 

The shared launch config is under 

org.eclipse.help.webapp/.externalToolBuilders
and named
JSP Builder.launch

Comment 2 Dani Megert 2015-11-30 03:50:01 EST

What is the output during the build?

When I clean the project I get this in my console:

Buildfile: C:\eclipse\workspaces\HEAD\Git\eclipse.platform.ua\org.eclipse.help.webapp\buildJSPs.xml

build:

compile:
BUILD SUCCESSFUL
Total time: 11 seconds


But I can't find any produced JSPs (or I'm looking in the wrong folder).

Are you running with some verbose/debug options?

Comment 3 David Williams 2015-11-30 04:10:48 EST

Doing the clean "auto build" I get the following: 


Buildfile: /home/davidw/gitLuna/eclipse.platform.ua/org.eclipse.help.webapp/buildJSPs.xml

build:

compile:
        [java] org.apache.jasper.JasperException: PWC6033: Error in Javac compilation for JSP
        [java] PWC6197: An error occurred at line: 318 in the jsp file: /advanced/workingSetManager.jsp
        [java] PWC6199: Generated servlet error:
        [java] The type org.eclipse.help.internal.workingset.WorkingSet cannot be resolved. It is indirectly referenced from required .class files
        [java] PWC6197: An error occurred at line: 318 in the jsp file: /advanced/workingSetManager.jsp
        [java] PWC6199: Generated servlet error:
        [java] The method getWorkingSet() from the type WorkingSetManagerData refers to the missing type WorkingSet
        [java] PWC6197: An error occurred at line: 321 in the jsp file: /advanced/workingSetManager.jsp
        [java] PWC6199: Generated servlet error:
        [java] The method getWorkingSet() from the type WorkingSetManagerData refers to the missing type WorkingSet

BUILD FAILED
/home/davidw/gitLuna/eclipse.platform.ua/org.eclipse.help.webapp/buildJSPs.xml:49: The following error occurred while executing this line:
/home/davidw/gitLuna/eclipse.platform.ua/org.eclipse.help.webapp/buildJSPs.xml:65: Java returned: 1

Total time: 2 seconds

= = = = = = = = = = = = = = = =

And if I try to run the buildjsp.xml with "run as Ant ...." I just get something like 

Buildfile: /home/davidw/gitLuna/eclipse.platform.ua/org.eclipse.help.webapp/buildJSPs.xml
build:
compile:

BUILD FAILED
/home/davidw/gitLuna/eclipse.platform.ua/org.eclipse.help.webapp/buildJSPs.xml:49: The following error occurred while executing this line:
/home/davidw/gitLuna/eclipse.platform.ua/org.eclipse.help.webapp/buildJSPs.xml:65: /home/davidw/gitLuna/eclipse.platform.ua/org.eclipse.help.webapp/${target_home}/plugins does not exist.

Total time: 383 milliseconds

= = = = = = = = = = =  

(please ignore the "gitLuna" in the directories ... it really is master branch (Neon) ... I am just not very good a keeping my directory *names* up to date. 

= = = = = = = = = = = =

Are you running on Windows? I am on Linux. Maybe it works on Window's, even with Curtis's name in that one file where the path is obviously for Windows. 

I have not tried on other OSs.

Comment 4 Dani Megert 2015-11-30 04:44:15 EST

(In reply to David Williams from comment #3)
> Doing the clean "auto build" I get the following: 
> 
> 
> Buildfile:
> /home/davidw/gitLuna/eclipse.platform.ua/org.eclipse.help.webapp/buildJSPs.xml
> 
> 
> build:
> 
> compile:
>         [java] org.apache.jasper.JasperException: PWC6033: Error in Javac


This works fine for me. I also verified that e.g. changing
classname="org.apache.jasper.JspC"
makes the build fail.

What I don't know is where it would place the JSPs.

Comment 5 David Williams 2015-11-30 12:43:00 EST

I've tried Windows, and it does "compile" there. Not sure if same results as Maven's task we use during the build but does work. So I've changed the title to say "not on Linux" and reduced severity to 'normal'. 

The *_jsp.class files and their *.java files are under 

/org.eclipse.help.webapp/bin/org/eclipse/help/internal/webapp/jsp

(you have to "refresh" and switch to resource view and adjust project explorer filters to see 'bin' directory, if you normally don't).

Comment 6 Dani Megert 2015-12-01 11:21:28 EST

(In reply to David Williams from comment #5)
> I've tried Windows, and it does "compile" there. Not sure if same results as
> Maven's task we use during the build but does work. So I've changed the
> title to say "not on Linux" and reduced severity to 'normal'. 
> 
> The *_jsp.class files and their *.java files are under 
> 
> /org.eclipse.help.webapp/bin/org/eclipse/help/internal/webapp/jsp
> 
> (you have to "refresh" and switch to resource view and adjust project
> explorer filters to see 'bin' directory, if you normally don't).

Yep, see them there.

Comment 7 David Williams 2015-12-02 10:49:44 EST

Now, even on Windows, if I just select the buildJSPs.xml file, and say to "run ant..." and pick 'build' as primary task to run, I get the errors below. I added the "echos" in my local vesion. 

I *thought* things like "workspace_loc" used to be given a value automatically? Has that never been true? Or, a change due to the way that the workspace is now kind of spread out, between the literal workspace location, and the loc Git clone? 

I'm just curious if there is a "bug" with that, or has it always been expected that users would "fill in" those type of variables to suit their local system? 

(I am such a newbie :) 

= = = = = 

Buildfile: C:\gitNeon\eclipse.platform.releng.aggregator\eclipse.platform.ua\org.eclipse.help.webapp\buildJSPs.xml
build:
     [echo] buld: workspacee_loc: ${workspace_loc}
     [echo] buld: target_home: ${target_home}
compile:
     [echo] target.folder: ${target.folder}

BUILD FAILED
C:\gitNeon\eclipse.platform.releng.aggregator\eclipse.platform.ua\org.eclipse.help.webapp\buildJSPs.xml:45: The following error occurred while executing this line:
C:\gitNeon\eclipse.platform.releng.aggregator\eclipse.platform.ua\org.eclipse.help.webapp\buildJSPs.xml:58: C:\gitNeon\eclipse.platform.releng.aggregator\eclipse.platform.ua\org.eclipse.help.webapp\${workspace_loc} does not exist.

Total time: 406 milliseconds

Comment 8 Eclipse Genie 2020-03-24 11:43:37 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.