Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 483159

Summary:	The SelectOperation and DeselectOperation do not undo the exact changes performed within execute.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	Matthias Wienand <matthias.wienand>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	4.0.0 / 3.11.0 (Neon) M5
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2015-11-27 04:18:06 EST

The SelectOperation and DeselectOperation currently only select/deselect content parts that were not previously selected/deselected already. However, when the operation is undone, more content parts might be deselected/selected, because the exact changes are not recorded within #execute().

To resolve the issue, both operations should record the selected/deselected content parts and deselect/select those within #undo().

Comment 1 Matthias Wienand

2015-12-18 08:37:55 EST

I ensured that both policies record the actually selected/deselected parts within execute() and only undo those changes within undo(). The code is published on the master branch, therefore, I resolve this ticket as fixed for 3.11.0M5.