Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 483076

Summary: Enable full text search for suggesting reviewers
Product: Community Reporter: Matthias Sohn <matthias.sohn>
Component: GerritAssignee: Eclipse Webmaster <webmaster>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: sasa.zivkov
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Matthias Sohn CLA 2015-11-26 04:32:42 EST
Gerrit learned a better way to suggest reviewers when you click the "Add reviewers to this change" button.

With the current settings you have to type a lot of letters until you get the right match. Trying with my own name on Gerrit@Eclipse when typing "Matthias" Gerrit shows 10 names starting with "Matthias" though since many users have the same first name my name is not in this list. When I continue typing "Matthias S" I get no match and only get my user when typing the full name "Matthias Sohn".

This is due to the fact that the default suggest algorithm is pretty silly. We implemented a better algorithm using an in-memory lucene index which is available in Gerrit 2.11. This algorithm can be selected by setting "suggest.fullTextSearch=true" [1]. We use this on our SAP internal Gerrit server with the following settings:
[suggest]
        from = 3
        fullTextSearch = true
        fullTextSearchMaxMatches = 10

and found that this works much better than the default algorithm. So for my above example on our SAP internal Gerrit (we have >10k users) it's sufficient to type "m soh" to get a perfect match on my own name. I can also just type my last name which doesn't work with the default algorithm.

Please configure this on Gerrit@Eclipse.

[1] https://git.eclipse.org/r/Documentation/config-gerrit.html#suggest
Comment 1 Eclipse Webmaster CLA 2015-11-30 13:29:06 EST
Done.

-M.