Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 483010

Summary:	[eslint] Provide rule for unecessary non-nls messages
Product:	[ECD] Orion	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	JS Tools	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	emoffatt, Michael_Rennie, Olivier_Thomann, steve_northover
Version:	10.0
Target Milestone:	11.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Curtis Windatt

2015-11-25 09:59:22 EST

We have a rule for missing-nls.  As we add more cases to this rule there are additional cases where spurious non-nls messages are left in the code.  We should have a rule to find these cases.

Comment 1 Curtis Windatt

2015-12-01 17:38:45 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0a7c70c458dec7470c7a5da90db8426f127ebcf7
Fixed in master

Added new rule
Merged logic to count literals on source lines with missing-nls rule so only runs once
Created quick fix for the rule
Added tests for both the rule and the quick fix
Rule defaults to off but can be turned on in settings