Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 482317

Summary: [rename] Inline rename does not rename identifier in catch block
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 11.0   
Target Milestone: 11.0   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Michael Rennie CLA 2015-11-16 13:21:58 EST
Consider the following snippet:

var status;
try {
	status = status ? status : {};
}
catch(err) {
	status = 0;
}

Steps:
1. select status in 'var status'
2. do 'rename member'
3. notice the occurrence of status in the catch block is not renamed
Comment 1 Michael Rennie CLA 2015-11-16 13:51:05 EST
Fix:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0f166fd4f5b2a616f390b66d21a9e03ad8277c81

turns out it was a problem in the version of the parser we use. This fix also fixed a content assist bug in catch blocks.