Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 482139

Summary:	Implement scroll and zoom actions/contribution items and demonstrate them in the Zest Graph view, MVC Logo view, and DOT Graph view.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	nyssen
Version:	0.2.0
Target Milestone:	5.0.0 (Oxygen) M5
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2015-11-13 11:53:37 EST

The GEF4 MVC Logo Example should provide a button (or similar) to change scroll offset and zoom level so that the whole diagram is visible within the viewport.

Comment 1 Alexander Nyßen

2016-02-03 07:22:51 EST

The same should be provided for the Zest Graph example. 

We should integrate support for a toolbar, a graphical context menu, or a flyout-toolbar within mvc (or all), into which the functionality could be integrated by default.

Comment 2 Matthias Wienand

2016-11-10 11:27:39 EST

Additionally, there should probably be a button to reset the scaling (i.e. zooming) within a viewer to 1.

Comment 3 Matthias Wienand

2017-01-03 12:12:44 EST

I implemented FitToSizeAction (fit contents within the viewport) and ResetViewportAction (reset zoom level) and added them to the toolbar of the DotGraphView. We still need to find nice icons for the functionality, as well as provide a mechanism for using such actions in a standalone context (no Eclipse).

Comment 4 Alexander Nyßen

2017-01-08 06:48:13 EST

We now have implemented the following actions/contribution items (so far added to Dot Graph view):

- Fit-to-Viewport (aka Fit-to-Size)
- Zoom-In, Zoom-Out, Zoom-Combo, Zoom-Scale
- Scroll-Center, Scroll-Top-Left, Scroll-Top-Right, Scroll-Bottom-Right, Scroll-Bottom-Left.

All actions come with respective icons (including @x2 high resolution versions). 

We should yet implement some action groups to bundle related functionalities (zoom and scroll respectively) and add them to the example views.

Comment 5 Alexander Nyßen

2017-01-08 06:50:45 EST

And IMHO, we should make the scale a bit shorter by default.

Comment 6 Matthias Wienand

2017-01-11 11:23:41 EST

I added action groups for zooming (ZoomActionGroup), scrolling (ScrollActionGroup), and fit-to-viewport (FitToViewportActionGroup). Additionally to the FitToViewportAction, I implemented FitToViewportLockAction that can be toggled to keep performing fit-to-viewport when the viewport size changes. Moreover, the ScrollActionGroup only displays the ScrollCenterAction in the toolbar, while the other scroll actions (top-left, top-right, bottom-left, and bottom-right) are accessible via a drop down menu next to the ScrollCenterAction.

I added toolbar contributions to the MVC Logo example and Zest Graph example using these action groups. The toolbar contribution for the Dot Graph view uses the defaults. The MVC Logo example adds an item to the zoom combo to perform fit-to-viewport and does not contribute the FitToViewportActionGroup, but only the FitToViewportLockAction. The Zest Graph example uses all three action groups, and adds an item for fit-to-viewport to the zoom combo, too.

The code is published on the master branch, therefore, I resolve this ticket as fixed for 5.0.0 M5.