Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 482122

Summary:	PropertyViewOnModelExplorerSelectionTests fails in the suite
Product:	[Modeling] Sirius	Reporter:	Esteban DUGUEPEROUX <esteban.dugueperoux>
Component:	Core	Assignee:	Esteban DUGUEPEROUX <esteban.dugueperoux>
Status:	CLOSED FIXED	QA Contact:	Florian Barbin <florian.barbin>
Severity:	normal
Priority:	P3	CC:	florian.barbin, laurent.redor, maxime.porhel
Version:	3.1.0	Keywords:	triaged
Target Milestone:	4.0.0M4
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/60341 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ca29c84b1c788a120cb90cb78f15836fea1e32e3 https://git.eclipse.org/r/60813 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7d5afd3d6dd93e4e3b20a94cd9273e0fdf5960fb
Whiteboard:

Description Esteban DUGUEPEROUX

2015-11-13 10:10:00 EST

PropertyViewOnModelExplorerSelectionTests.testPropertyViewEditionOnModelExplorerViewSelection() test pass correctly when executed alone but fails when executed in the suite with CloseWithoutSavingTest and LockedModelExplorerTest executed before.
LockedModelExplorerTest do some test on ModelExplorer view closing without restoring it in teardown(), but even restoring it the PropertyViewOnModelExplorerSelectionTests.testPropertyViewEditionOnModelExplorerViewSelection() test fails.
This seems due to the use of singleton ViewHelper.INSTANCE.getContentProvider() which seems disposed on ModelExplorer view close and not recreated on ModelExplorer view restore.
My analysis is not finished but a temporary work-around is to reset the singleton contentProvider on ContentProvider dispose.

Comment 1 Eclipse Genie

2015-11-13 10:49:59 EST

New Gerrit change created: https://git.eclipse.org/r/60341

Comment 2 Eclipse Genie

2015-11-16 04:30:17 EST

Gerrit change https://git.eclipse.org/r/60341 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ca29c84b1c788a120cb90cb78f15836fea1e32e3

Comment 3 Esteban DUGUEPEROUX

2015-11-16 12:04:16 EST

Fixed.

Comment 4 Eclipse Genie

2015-11-19 12:28:28 EST

New Gerrit change created: https://git.eclipse.org/r/60813

Comment 5 Eclipse Genie

2015-11-20 03:27:01 EST

Gerrit change https://git.eclipse.org/r/60813 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7d5afd3d6dd93e4e3b20a94cd9273e0fdf5960fb

Comment 6 Laurent Redor

2015-11-20 03:28:41 EST

Also fixed on v3.1.x branch with another solution (just change the tests order).

Comment 7 Florian Barbin

2016-05-20 09:16:34 EDT

The test passes correctly on swtbot part2.

Comment 8 Pierre-Charles David

2016-06-24 08:04:05 EDT

Available in Sirius 4.0.0.