Bugzilla – Full Text Bug Listing
| Summary: | More commits message under Outgoing section | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | xin chen <jiudechenxin> |
| Component: | Node | Assignee: | Silenio Quarti <Silenio_Quarti> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | ayl051, grant_gayed, mengzhixing0228, pwebster, Silenio_Quarti |
| Version: | 10.0 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 474353 | ||
|
Description
xin chen
What's the scenario that I need to do to reproduce this problem on https://orionhub.org? PW When reloading the git page, under the outgoing section, even there's no commit but it still showing"more commit for outgoing" (In reply to Paul Webster from comment #1) > What's the scenario that I need to do to reproduce this problem on > https://orionhub.org? > > PW I started working on this bug three weeks ago. In order to fix the bug, I traced the code by using Chrome debug tool, at the end I assumed the problem might in the gitCommitList.js, gitCommands.js and gitmessages.js. First in gitCommitList.js, function “processMoreChildren”, there’s a container to hold childrenPorcess called fullList. I think the problem is even the code was check fullList is empty or not but even the condition was empty, it still showing the message. So I added some condition to check the fullList. But the problem didn’t solve. Then I stepped into getChildren function in gitCommitList.js. There’s a condition called “parentItem.Type === “Outgoing”” I think the “if (outgoingCommits.Children[0]) “ to check if there’s an element in Children, if there’s an element then set it to true. In the else condition, I changed the code to set outgoingCommits.outgoing to false instead of commit.outgoing.Because I think outgoingCommit control the message to show. Unfortunately, it still not works. I don't see this at OrionHub, I'm going to assume that you're seeing this with a local Node server. Fixed in latest |