Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 481732

Summary: Manage editor closing on undo of DRepresentationContainer addition having a opened representation
Product: [Modeling] Sirius Reporter: Maxime Porhel <maxime.porhel>
Component: CoreAssignee: Maxime Porhel <maxime.porhel>
Status: CLOSED FIXED QA Contact: Laurent Redor <laurent.redor>
Severity: normal    
Priority: P3 CC: esteban.dugueperoux, florian.barbin, laurent.redor, maxime.porhel
Version: 3.1.0Keywords: triaged
Target Milestone: 3.1.3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/60300
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=635c6a6928356ce53bc5bae469f7291289362793
Whiteboard:
Bug Depends on: 481403    
Bug Blocks:    

Description Maxime Porhel CLA 2015-11-09 10:46:29 EST 
+++ This bug was initially created as a clone of Bug #481403 +++

Undoing a command which has done DRepresentationContainer addition with a DRepresentation for which a editor is opened, the editor will not be closed.
This occurs because the DialectEditorCloser through its filter doesn't manage DRepresentationContainer removal.
Comment 1 Eclipse Genie CLA 2015-11-13 04:44:07 EST 
New Gerrit change created: https://git.eclipse.org/r/60300
Comment 3 Maxime Porhel CLA 2015-11-16 08:43:25 EST 
Resolved on v3.1.x branch

(still waiting for test which should be cherry-picked when done for master).
Comment 4 Florian Barbin CLA 2015-11-20 10:48:19 EST 
waiting for Bug #481403 details to validate this issue
Comment 5 Laurent Redor CLA 2015-12-07 08:15:39 EST 
There is no real scenario to validate this issue. The only way to validate it, is to create a test that uses specific API (not possible via UI). This test will be done later (with bug 481403 on master).
Comment 6 Pierre-Charles David CLA 2015-12-15 05:26:30 EST 
Available in Sirius 3.1.3 released on 2015-12-08.