Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 481671

Summary: "keyAssistEditButton" id needs to be unique
Product: [ECD] Orion Reporter: Carolyn MacLeod <Carolyn_MacLeod>
Component: ClientAssignee: Carolyn MacLeod <Carolyn_MacLeod>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/59916
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5f74bd90fff3e6af87faebdb692d90d5976a5a5c
Whiteboard:

Description Carolyn MacLeod CLA 2015-11-08 21:16:45 EST 
keyAssist.js:

Each item in the keyAssistTable has a button with id "keyAssistEditButton".
These need to be unique.

We could either:
- append the same 'count' field that is used to make the item's row id unique
  (which is what the attached patch does):
   eb.id = "keyAssistEditButton" + this._idCount;

- or remove the id altogether. As far as I can tell, it is never used.
Comment 1 Eclipse Genie CLA 2015-11-08 21:22:09 EST 
New Gerrit change created: https://git.eclipse.org/r/59916
Comment 2 Eric Moffatt CLA 2015-11-09 14:38:49 EST 
I've sent this one back so you can modify it to take the 'remove the id' path ('less is more'...;-).

BTW, should we add an 'aria-lable' to these buttons ? If so can you open an separate defect for it ? This will add to your commits towards committer-ism stats :).
Comment 3 Carolyn MacLeod CLA 2015-11-11 00:11:45 EST 
Ok, "patch set 2" in gerrit removes the  id altogether. Less is more!  :)
Please review again: https://git.eclipse.org/r/59916

Opened bug 481897 to add an aria-label to the edit buttons.
Comment 5 Carolyn MacLeod CLA 2015-11-11 10:47:52 EST 
Fixed by the commit in comment 4.