Bug 481491

Description Jonas Wiklund 2015-11-05 05:27:57 EST

When completing items (types or static methods) on a generic class that is not imported it eclipse incorrectly adds generic parameters (does not happen if the type is already imported).

Eg:

(if no import of java.util.Map exists)

Map.(Ctrl+Space Choose Map.Entry) -> Map<K,V>.Entry<K.V>

(if java.util.Map is imported)

Map.(Ctrl+Space Choose Map.Entry) -> Map.Entry<K,V>

This also happens for static methods

eg guavas ImmutableMap:

(if no import of com.google.common.collect.ImmutableMap)

ImmutableMap.(Ctrl+Space Choose of) -> ImmutableMap<K,V>.of()

(if com.google.common.collect.ImmutableMap is imported)

ImmutableMap.(Ctrl+Space Choose of) -> ImmutableMap.of()


A quick fix is to add

return ch != '<' && ch != '.';
instead of
return ch != '<';

at the end of shouldAppendArguments in LazyGenericTypeProposal. I think it never makes sense to include generic arguments before a dot in Java so it should be safe, but there is probably a more correct solution (not using the generic type as a requirement when you need to import the type for example).

On a related note, how do you build a plugin and use it in my normal eclipse installation? Using eclipse to export a eclipse plugin or building it with maven creates a plugin that is not recognized by eclipse (The manifest is somewhat different from the official one).