Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 481403

Summary:	Manage editor closing on undo of DRepresentationContainer addition having a opened representation
Product:	[Modeling] Sirius	Reporter:	Esteban DUGUEPEROUX <esteban.dugueperoux>
Component:	Core	Assignee:	Esteban DUGUEPEROUX <esteban.dugueperoux>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	florian.barbin, laurent.fasani, maxime.porhel
Version:	3.1.0	Keywords:	triaged
Target Milestone:	4.0.0M4
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/59654 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=175fe12b8b894e10f7834a22b55cd76d7e797ce7 https://git.eclipse.org/r/62651 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3699b3909c9cc6ee34b2cf214c6e1dc37372f098 https://git.eclipse.org/r/64385 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=08c0960a445486ed88f545e0d97d482dbd58e778
Whiteboard:
Bug Depends on:
Bug Blocks:	481732

Description Esteban DUGUEPEROUX

2015-11-04 07:34:26 EST

Undoing a command which has done DRepresentationContainer addition with a DRepresentation for which a editor is opened, the editor will not be closed.
This occurs because the DialectEditorCloser through its filter doesn't manage DRepresentationContainer removal.

Comment 1 Eclipse Genie

2015-11-04 07:35:30 EST

New Gerrit change created: https://git.eclipse.org/r/59654

Comment 2 Eclipse Genie

2015-11-12 04:35:03 EST

Gerrit change https://git.eclipse.org/r/59654 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=175fe12b8b894e10f7834a22b55cd76d7e797ce7

Comment 3 Esteban DUGUEPEROUX

2015-11-12 04:35:19 EST

Merged.

Comment 4 Florian Barbin

2015-11-20 10:47:25 EST

Can you provide us more details to validate this issue ?

Comment 5 Esteban DUGUEPEROUX

2015-11-24 04:09:30 EST

The only way to validate this is by writting a auto test.

Comment 6 Eclipse Genie

2015-12-14 12:16:25 EST

New Gerrit change created: https://git.eclipse.org/r/62651

Comment 7 Eclipse Genie

2016-01-14 10:24:57 EST

Gerrit change https://git.eclipse.org/r/62651 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3699b3909c9cc6ee34b2cf214c6e1dc37372f098

Comment 8 Eclipse Genie

2016-01-14 11:28:26 EST

New Gerrit change created: https://git.eclipse.org/r/64385

Comment 9 Eclipse Genie

2016-01-14 11:28:37 EST

Gerrit change https://git.eclipse.org/r/64385 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=08c0960a445486ed88f545e0d97d482dbd58e778

Comment 10 Laurent Fasani

2016-02-09 11:27:29 EST

validated by added junit test in comment 9

Comment 11 Pierre-Charles David

2016-06-24 07:59:18 EDT

Available in Sirius 4.0.0.