| Summary: | [Papyrus] Permissions setup and folder creation | ||
|---|---|---|---|
| Product: | Community | Reporter: | Francois Le Fevre <francois.le-fevre> |
| Component: | CI-Jenkins | Assignee: | CI Admin Inbox <ci.admin-inbox> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | benoit.maggi, cletavernier, francois.le-fevre, mikael.barbero, rschnekenburger, sebastien.gerard, webmaster |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Francois Le Fevre
You've done your homework very well ;) I've no comments to make on what you said. I've created the "components" folder and set the proper permissions for your HIPP. Hello Mickael, thanks to the tasks done. however when I have tried to call the /shared/common/gerrit-utils/authorizeGerritBuild.sh $GERRIT_PROJECT $BUILD_URL from my hudson job it is failing: https://hudson.eclipse.org/papyrus/view/Sysml/job/papyrus-sysml-gerrit/400/ because the $GERRIT_PROJECT is linking to papyrus/org.eclipse.papyrus-sysml and we do not have any folder in /shared/${project}/contributor_whitelist.txt Could we have also a folder /shared/papyrus/ as mylyn etc... ? Thanks again. Francois You should use your own existing folder /shared/modeling/mdt/papyrus. Mylyn is a top level project, that's the reason why they have a folder right under /shared. Mikael, I do agree with you when saying papyrus is not a top level project. but it seems to be linked to /shared/modeling/papyrus (no mdt folder?) Even if, we cannot use the default CBI /shared/common/gerrit-utils/authorizeGerritBuild.sh $GERRIT_PROJECT $BUILD_URL $GERRIT_PATCHSET_UPLOADER_EMAIL because $GERRIT_PROJECT return for instance papyrus/org.eclipse.papyrus-sysml and not /shared/modeling/papyrus so the CBI script is working for top level project and low level project. So do you agree we will need to customize the CBI script? An additional element, in the script they use the following url
${GERRIT_ACCESS_URL}${project}
>>this url exists
https://git.eclipse.org/r/access/?project=modeling/papyrus/org.eclipse.papyrus-sysml
>>this one does not exist
https://git.eclipse.org/r/access/?project=papyrus/org.eclipse.papyrus-sysml
Francois, you're right. I've overlooked at how we match gerrit's project names and project paths under /shared. I am thinking of creating a subfolder in shared (e.g. /shared/gerrit_whitelists) where all projects will put their whitelist files because I don't want to create a duplicate project right under /shared without this top folder. I will check with mylyn if they are ok with that and will come back to you shortly. /shared/gerrit-contributor-whitelists/papyrus has been created and you should now be able to add contributor_whitelist.txt files into it. Note that you have to add them in proper subfolders depending on the gerrit project name, e.g. /shared/gerrit-contributor-whitelists/papyrus/org.eclipse.papyrus or /shared/gerrit-contributor-whitelists/papyrus/org.eclipse.papyrus-sysml The symlinks work so I suggest you create a top level file /shared/gerrit-contributor-whitelists/papyrus/contributor_whitelist.txt and create symlinks to it from subfolder. Please reopen if you face issues. Thanks I have done the test with the follwoing patch https://git.eclipse.org/r/#/c/60911/ First pass, I was not member of the white list, so it was refused Secund pass Camille add me to the white list, so it was accepted ! So now I continue in oder to test the promote/publish of the p2 Thanks |