Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 481292

Summary:	"Polish" API of SelectionModel
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF MVC	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	4.0.0 / 3.11.0 (Neon) M3
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2015-11-03 04:18:57 EST

The naming of methods in the selection model seems to be misleading for clients. We should adjust these to be easier to comprehend, ensuring also that things are comparable to the naming within HoverModel and FocusModel.

Comment 1 Alexander Nyßen

2015-11-03 04:38:08 EST

I pushed the following changes to origin/master.

- Renamed updateSelection() to setSelection().
- Renamed appendSelection() to appendToSelection() and adjusted its implementation to be complementary to prependSelection().
- Renamed select() to prependToSelection().
- Renamed deselectAll() to clearSelection().
- Renamed deselect() to removeFromSelection().
- Renamed getSelected() to getSelection().
- Removed internal set representation, which was unneccessary.
- Updated javadoc to be more explicit and concise.
- Added SelectionModelTests to mvc test bundle.

Resolving as fixed in 3.11.0 M3.