Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 481254

Summary: Rename fails silently when element is a function in a different file
Product: [ECD] Orion Reporter: Steve Northover <steve_northover>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P2 CC: curtis.windatt.public
Version: 10.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
screen shot none

Description Steve Northover CLA 2015-11-02 11:38:03 EST 
1) get minesweeper-objects
2) open main.js
3) click on setValue() in line 13
4) Tools->Rename Element
5) BUG: Nothing happens

This looks bad because I have the option enabled where references are selected by the caret so when I click on setValue(), all references in the file are highlighted yet 'Rename Element' doesn't work and fails silently.
Comment 1 Michael Rennie CLA 2015-11-05 14:24:53 EST 
in-line renaming of a member expression is not supported. It seems as though some changes in command progress have broken the message that is supposed to be shown if you try and rename member expression parts.

Silenio mentioned this one could be related:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=49243ac3203ea361f9c7b7f88e1d70d55308f2e6
Comment 2 Michael Rennie CLA 2015-11-10 17:14:21 EST 
Created attachment 257869 [details]
screen shot

Silenio has fixed the busted status code, so now you will see the message shown in the screen shot if you try to in-line rename the function (in a member expression).
Comment 3 Michael Rennie CLA 2015-11-10 17:15:47 EST 
I'm going to close this as worksforme. We already have bug 472545 open to expand in-line renames to member expressions.