Bug 480998

Description Martin Domig 2015-10-29 09:54:40 EDT

Created attachment 257623 [details]
Workbench demo / selection view: include a HelpSearchContributionItem in the selection view, changes setFocus() to set the focus to a label instead

When a view title has focus, the client crashes when "tabbing away" from it - if the view has a contribution item.

Steps to reproduce:
1. apply the attached patch to the workbench demo.
2. start the workbench demo.
3. select something so that the selection view shows some content.
4. click on the title of the selection view.
5. hit tab twice - you should get the stack trace below.

We can reproduce this in RAP 2.3, 3.0 and 3.1.

It seems related to the focus bug #439044: if setFocus() of the selection view gives the focus to the list, this bug does not trigger (but then the contribution is useless). If the focus is given to the label instead, the bug triggers.

I'll also attach a proposed fix.


Stack trace:

Error: TypeError: this._hoverItem._onKeyUp is not a function. (In 'this._hoverItem._onKeyUp( event )', 'this._hoverItem._onKeyUp' is undefined)

  line: 52495
  column: 33
  sourceURL: http://localhost:9090/rwt-resources/rap-client.js
  Stack: _onKeyUp@http://localhost:9090/rwt-resources/rap-client.js:52495:33
_dispatchEvent@http://localhost:9090/rwt-resources/rap-client.js:3865:22
dispatchEvent@http://localhost:9090/rwt-resources/rap-client.js:3806:26
_processKeyEvent@http://localhost:9090/rwt-resources/rap-client.js:15410:28
_onkeyevent_post@http://localhost:9090/rwt-resources/rap-client.js:15366:28
_onKeyEvent@http://localhost:9090/rwt-resources/rap-client.js:15347:30
http://localhost:9090/rwt-resources/rap-client.js:624:22
  Debug: on