Bugzilla – Full Text Bug Listing
| Summary: | Add Tests for ModelAssembler | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Jonas Helming <jhelming> |
| Component: | UI | Assignee: | Jonas Helming <jhelming> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | abuzila, Lars.Vogel, markus.kell.r |
| Version: | 4.5 | ||
| Target Milestone: | 4.6 M7 | ||
| Hardware: | PC | ||
| OS: | Windows NT | ||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=478399 https://git.eclipse.org/r/66520 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c2f3d33e6f34013650a63fa401e7f5d9c0b89b76 https://git.eclipse.org/r/70046 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=57525bc2cc2106eb13d072b42a70b357c377ba41 |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 475934, 487748 | ||
|
Description
Jonas Helming
We need to refactor the class a bit to make it testable and add tests New Gerrit change created: https://git.eclipse.org/r/66520 Gerrit change https://git.eclipse.org/r/66520 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c2f3d33e6f34013650a63fa401e7f5d9c0b89b76 Is it important that the /org.eclipse.e4.ui.tests/data/ModelAssembler/*.xml files don't start with an XML declaration, e.g.: <?xml version="1.0" encoding="UTF-8"?> https://www.w3.org/TR/xml/#sec-prolog-dtd says they "SHOULD". We're periodically running a tool that checks this, and I'd prefer to add the prolog rather than muting the warnings. New Gerrit change created: https://git.eclipse.org/r/70046 (In reply to Eclipse Genie from comment #5) > New Gerrit change created: https://git.eclipse.org/r/70046 Jonas, can you please decide if it is OK to add these headers? Gerrit change https://git.eclipse.org/r/70046 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=57525bc2cc2106eb13d072b42a70b357c377ba41 Done... |