Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 480438

Summary:	Find Refs: Matches sometimes are not assigned with confidence.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	10.0
Target Milestone:	10.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2015-10-22 11:13:37 EDT

I found this when fixing bug Bug 480435. It happens rarely but here is a set of steps to reproduce.
In Orion client code base, open editorCommands.js
1. Find "registerCommands", at line 205, for example, select "registerCommands".
2. CTRL+SHIFT+Y, you will find the last match in the category view does not have confidence. 
3. Same thing in file view mode.

Comment 1 Michael Rennie

2015-10-22 11:32:00 EDT

Good catch. This is because the callee property of the CallExpression is a MemberExpression (a somewhat common pattern) and we do not unwind the expression to check the base property name.

Comment 2 Michael Rennie

2015-10-22 17:35:14 EDT

Part of the commit 

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=88337d56f0d211b31af440d4dc5f10e60bf30817

added support to default to setting the category to 'partial' if no other category has been set on the match.

marking this fixed.