Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 480348

Summary: nextAnnotation no longer show the annotation's tooltip
Product: [ECD] Orion Reporter: Eric Moffatt <emoffatt>
Component: ClientAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, Michael_Rennie, Silenio_Quarti
Version: 10.0   
Target Milestone: 10.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Eric Moffatt CLA 2015-10-21 15:37:20 EDT 
When we refactored the tooltip API we forgot to change the code in actions.js that was showing the tooltip when using nextAnnotation (Ctrl + . / Ctrl + ,).
Comment 1 Eric Moffatt CLA 2015-10-21 15:39:47 EDT 
I've updated the code to use the same pattern as the 'Show Tooltip' (F2) code does...

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=647b96c35ceb60ad87baae01d3adcde6e72718f4
Comment 2 Curtis Windatt CLA 2015-10-21 16:06:55 EDT 
Reopening, whenever I use the keybinding to jump to an annotation that the editor has to scroll to the tooltip immediately opens and closes (flashes).

Because occurrences are also annotations as the caret is moved the annotations change causing some additional weirdness.
Comment 3 Michael Rennie CLA 2015-10-21 16:14:32 EDT 
(In reply to Curtis Windatt from comment #2)
> Because occurrences are also annotations as the caret is moved the
> annotations change causing some additional weirdness.

One bit of weirdness I saw is in bug 480349.
Comment 4 Eric Moffatt CLA 2015-10-23 15:02:05 EDT 
Just committed:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=553511ff3cebdf85f26442b26f529f6c0007c1f9

this removes the hiding of the tooltip on scroll events out from editor.js and moves it to tooltip.js.

Also adds checking in the mousemove handler to check for spurious 'no-op' events (neither clientX nor  clientY change -> ignore)
Comment 5 Curtis Windatt CLA 2015-10-27 11:07:35 EDT 
(In reply to Eric Moffatt from comment #4)
> Just committed:
> 
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/
> ?id=553511ff3cebdf85f26442b26f529f6c0007c1f9
> 
> this removes the hiding of the tooltip on scroll events out from editor.js
> and moves it to tooltip.js.
> 
> Also adds checking in the mousemove handler to check for spurious 'no-op'
> events (neither clientX nor  clientY change -> ignore)

I'm still seeing the tooltip disappear when the editor has to scroll to show the next annotation.