Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 480343

Summary: Find Refs: Should hide categories when they are empty.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: JS ToolsAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie, Silenio_Quarti
Version: 10.0   
Target Milestone: 10.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2015-10-21 14:38:51 EDT
Find refs commands provides a set of categories but there are case on UI side that some of the categories are not filled up.
We should still show the category there but if user expand it we should show "no Matches". In Git repository page, as Silenio mentioned, we do the similar thing: If there is no incoming changes, click on it will still expand but jsut showing "No Changes".
Comment 1 Michael Rennie CLA 2015-10-21 15:18:37 EDT
(In reply to libing wang from comment #0)
> Find refs commands provides a set of categories but there are case on UI
> side that some of the categories are not filled up.
> We should still show the category there but if user expand it we should show
> "no Matches". In Git repository page, as Silenio mentioned, we do the
> similar thing: If there is no incoming changes, click on it will still
> expand but jsut showing "No Changes".

I would have to disagree. In the git case it is expected there is always incoming / outgoing stuff (or maybe not, but you also want to know that). In the search case, you only want to see search matches, showing empty groups with filler children adds no value, just adds more things to click through / ignore. 

Look at it another way: the search view doesn't show you all of the files that don't have matches in them, only the ones that do.
Comment 2 libing wang CLA 2015-10-21 15:55:30 EDT
I kind of agree with Mike now.
Pushed http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3725e11173e024672fe4249b9b6c585c2e2feb3a.

We can change it later if we all agree that we should show "No matches"
Comment 3 libing wang CLA 2015-10-21 15:55:49 EDT
Fixed.