Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 480203

Summary:	SemanticPropertySection should test IPermissionAuthority.canEditInstance() on ModelExplorer view selection
Product:	[Modeling] Sirius	Reporter:	Esteban DUGUEPEROUX <esteban.dugueperoux>
Component:	Core	Assignee:	Esteban DUGUEPEROUX <esteban.dugueperoux>
Status:	CLOSED FIXED	QA Contact:	Florian Barbin <florian.barbin>
Severity:	normal
Priority:	P3	CC:	florian.barbin, laurent.redor, maxime.porhel
Version:	3.0.0	Keywords:	triaged
Target Milestone:	4.0.0M4
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/58505 https://git.eclipse.org/r/59026 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a10c65ef20fb531528154b740b94c2adb746db9d https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5e82f5a1f1d77e353c3c6bbd6e86d5e5497f3cb5 https://git.eclipse.org/r/60046 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c90732ceb6fc490bac8f91b865979bf1a6fee8a8
Whiteboard:
Bug Depends on:
Bug Blocks:	481731

Description Esteban DUGUEPEROUX

2015-10-20 08:27:35 EDT

In SemanticPropertySection classes for all dialects, we test IPermissionAuthority.canEditInstance() to allow properties edition or not but we don't test it for SemanticPropertySection used for ModelExplorer view selection.
We should test it.

Comment 1 Eclipse Genie

2015-10-20 08:34:21 EDT

New Gerrit change created: https://git.eclipse.org/r/58505

Comment 2 Esteban DUGUEPEROUX

2015-10-21 03:58:44 EDT

Scenario having a locked object in selection in the Model Explorer view:
1. Display the properties view on this selection and try to modify this object, KO the edition is possible but should not as on selection in dialect editor.

Comment 3 Eclipse Genie

2015-10-27 11:49:39 EDT

New Gerrit change created: https://git.eclipse.org/r/59026

Comment 4 Esteban DUGUEPEROUX

2015-10-27 11:50:43 EDT

Auto test is proposed in https://git.eclipse.org/r/59026 to show the issue and validate the fix.

Comment 5 Eclipse Genie

2015-11-09 11:33:57 EST

Gerrit change https://git.eclipse.org/r/58505 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a10c65ef20fb531528154b740b94c2adb746db9d

Comment 6 Eclipse Genie

2015-11-09 11:34:28 EST

Gerrit change https://git.eclipse.org/r/59026 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5e82f5a1f1d77e353c3c6bbd6e86d5e5497f3cb5

Comment 7 Eclipse Genie

2015-11-10 11:46:56 EST

Gerrit change https://git.eclipse.org/r/60046 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c90732ceb6fc490bac8f91b865979bf1a6fee8a8

Comment 8 Esteban DUGUEPEROUX

2015-11-12 09:42:37 EST

Fixed.

Comment 9 Florian Barbin

2016-05-20 06:22:19 EDT

With a shared modeling project and the Cars MM:
* User1 lock a Car
* User2 try to edit the car name from model explorer view via the properties view.
* User2 can't edit the name field => OK
* User1 release the lock
* User2 still can't edit the field => KO

Comment 10 Florian Barbin

2016-05-20 07:48:55 EDT

I set back this issue as resolved since the use case is not predictable and seems more due to the collaborative mode

Comment 11 Pierre-Charles David

2016-06-24 08:01:37 EDT

Available in Sirius 4.0.0.