Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 479838

Summary: Outline view not available for Java file
Product: [Eclipse Project] JDT Reporter: Sarika Sinha <sarika.sinha>
Component: TextAssignee: Markus Keller <markus.kell.r>
Status: CLOSED FIXED QA Contact:
Severity: blocker    
Priority: P3 CC: daniel_megert, Lars.Vogel, markus.kell.r
Version: 4.6   
Target Milestone: 4.6 M3   
Hardware: All   
OS: All   
Whiteboard:

Description Sarika Sinha CLA 2015-10-15 05:14:35 EDT
Outline view is not available for java files in the latest I build.

Eclipse SDK

Version: Neon (4.6)
Build id: I20151014-1100

Not sure if it is related but only for 1 file in my workspace, Ctrl+o is also not working.
Comment 1 Sarika Sinha CLA 2015-10-15 05:19:52 EDT
It works fine with Oct 13th I Build.
Comment 2 Markus Keller CLA 2015-10-15 06:40:09 EDT
Tricky problem. The trigger was http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=d17844220c08f1f54a0133fde8a55e16d76c179c from bug 478864, which added one more stack element to calls to getAdapter. This invalidated the workaround for bug 391253, which assumed that the ContentOutline can be found at a fixed position in the call stack.

The fix is to make JavaEditor#isCalledByOutline() more resilient and not look at a fixed position in the call stack.

Fixed together with Dani with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=d11c46542d32fa82a972a39ca0bb788d757d06c0
Comment 3 Dani Megert CLA 2015-10-16 03:46:54 EDT
Verified in eclipse-SDK-N20151015-2000-win32-x86_64.
Comment 4 Sarika Sinha CLA 2015-10-19 02:47:40 EDT
Closing.