Bugzilla – Full Text Bug Listing
| Summary: | Git repositories page, git commit history should under history section. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | xin chen <jiudechenxin> | ||||||||
| Component: | Node | Assignee: | Silenio Quarti <Silenio_Quarti> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | ayl051, mengzhixing0228, pwebster, Silenio_Quarti | ||||||||
| Version: | 10.0 | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Mac OS X | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 474353 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
xin chen
Also missing committer profile picture Current changes under alvinylee/479702 PW Alvin, thanks for alvinylee/479702.
It has a merge with one of the latest origin/masters, but we always use branch.master.rebase=true. You can fix this:
1. check out your branch
2. git checkout -b alvinylee/479702-2
3. git reset --hard <your first commit>
4. git commit --amend and fix your author and committer email and name:
Author: root <root@localhost.localdomain> :-)
5. get cherry-pick <your second commit>
6. repeat 4
But ...
This error has to do with what the node server version of orion returns to the client. The client code works fine.
Things that the server returns from source files under orion.client/modules/orionode/lib/git are what probably cause your problems.
Created attachment 258226 [details]
Responses from the server from orionhub
Here's something I asked for earlier. Here is the list of some responses returned to the git page from orionhub.org (a server that works).
You need to collect a similar list of responses from the node orion server, collect them in a text file, and patch them here.
The idea is to clone the same *very* small repo on orionhub.org and your node server. Then compare the responses sent back to the git page one by one. Where are they different? That's probably where the node server git implementation needs some work.
Please get the similar pattern (preferably for the same test git repo) posted to this bug as soon as you can.
Use node-inspector to debug your node server (google chrome). Use the network view (firefox, chrome, whatever) to see the client calls to the server and the response.
PW
Created attachment 258316 [details]
Responses from the server from orionode
That's a good start, the next step is to compare the return values, figuring out what orionode is not returning correctly (assume the orionhub one is correct). PW Created attachment 258455 [details]
OrionHub response vs Orionode response
It seems like that first return is the one to fix up:
"Children": [{
"CloneLocation": "/gitapi/clone/file/pwebster-OrionContent/paulweb515.github.io/", ....
PW
Fixed in latest |