Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 479386

Summary: Transaction operation in AbstractDomain should be reverse undoable.
Product: [Tools] GEF Reporter: Alexander Nyßen <nyssen>
Component: GEF MVCAssignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.2.0   
Target Milestone: 4.0.0 / 3.11.0 (Neon) M3   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 479388    

Description Alexander Nyßen CLA 2015-10-09 03:26:55 EDT 
The current composite operation within AbstractDomain is forward-undoable. This is not correct and causes problem, e.g. when undoing a connection creation in the logo example (as there we do not have a single composite commit operation but execute two directly via the domain).

We should change the transaction operation to be a reverse-undoable operation instead.
Comment 1 Alexander Nyßen CLA 2015-10-09 03:29:33 EDT 
Changed signatures of transaction field and related creation operation to be AbstractCompositeOperation. Ensured creation operation returns a    ReverseUndoableCompositeOperation.

Pushed all changes to origin/master. Resolving as fixed in 3.11.0 M3.