Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 479126

Summary: PERSPECTIVE_BAR_EXTRAS setting not taken into account
Product: [Eclipse Project] Platform Reporter: Jonas Helming <jhelming>
Component: UIAssignee: Jonas Helming <jhelming>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: drew, manuel.steurer, peter, stefan.prieschl
Version: 4.5   
Target Milestone: 4.6 M5   
Hardware: PC   
OS: Windows NT   
See Also: https://git.eclipse.org/r/58607
https://git.eclipse.org/r/64214
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=afda9098eb3d34c91bf7db0ee675493169b02773
Whiteboard:
Attachments:
Description Flags
Patch which enables the setting none

Description Jonas Helming CLA 2015-10-06 05:44:49 EDT 
see Bug 423136
Comment 1 Jonas Helming CLA 2015-10-06 05:46:19 EDT 
Stefan, are you considering a contribution on this one?
Comment 2 Stefan Prieschl CLA 2015-10-06 05:58:35 EDT 
No, i don't have the time for a contribution at the moment.
Comment 3 Manuel Steurer CLA 2015-10-16 08:10:37 EDT 
Created attachment 257298 [details]
Patch which enables the setting

The attached patch makes the PERSPECTIVE_BAR_EXTRAS setting work for me. There is at least 1 difference to pure e3 behaviour, in e3 the default perspective comes first, with my patch on e4 compat it comes last. As a workaround, you can specify the desired order if you include the default perspective in the setting's value.
Comment 4 Jonas Helming CLA 2015-10-16 08:14:45 EDT 
Thank you for the contribution!
Could you kindly submit it to Gerrit, so I can review it?

see http://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#eclipsegerritcontribgution_pushsetup
Comment 5 Eclipse Genie CLA 2015-10-21 08:42:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/58607
Comment 6 Jonas Helming CLA 2015-10-30 10:06:19 EDT 
Could you have a look at my comments?
Comment 7 Eclipse Genie CLA 2016-01-13 04:07:25 EST 
New Gerrit change created: https://git.eclipse.org/r/64214
Comment 9 Jonas Helming CLA 2016-01-15 08:28:36 EST 
Contribution accepted, Thank you Manuel! Please verify in the next nightly build.
Comment 10 Manuel Steurer CLA 2016-01-18 03:06:07 EST 
Verified in N20160117-2000
Comment 11 Lars Vogel CLA 2017-12-20 04:05:51 EST 
*** Bug 382625 has been marked as a duplicate of this bug. ***