Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 479049

Summary:	Add a colored background, completion and validation for VSM fields representing feature names
Product:	[Modeling] Sirius	Reporter:	Julien Dupont <julien.dupont>
Component:	Diagram	Assignee:	Project Inbox <sirius.diagram-inbox>
Status:	CLOSED FIXED	QA Contact:	Laurent Redor <laurent.redor>
Severity:	enhancement
Priority:	P3	CC:	cedric.brun, etienne.juliot, laurent.redor, maxime.porhel, nik.manolov, pierre-charles.david
Version:	unspecified	Keywords:	triaged
Target Milestone:	5.0.0
Hardware:	PC
OS:	Windows NT
See Also:	https://git.eclipse.org/r/71322 https://git.eclipse.org/r/93792 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=02f266cd9d0d5b83346755a8edc72f66a5ff8514 https://git.eclipse.org/r/97447 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d0c751786c8aaa67514c92c910984e501ce13e84 https://git.eclipse.org/r/97584 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=045818d87118f5a9f6dddce79df9d691ade270a8 https://bugs.eclipse.org/bugs/show_bug.cgi?id=517073 https://git.eclipse.org/r/98531 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a3746657f489fc257a9f614b41ff84c15adca44c
Whiteboard:

Description Julien Dupont

2015-10-05 09:58:49 EDT

These fields do not have background color. They should have a green background as the "Domain Class" field.
They should have the completion, for choose the feature available.
Fields concerned:
"Reference Name" in "Create Instance" Operation
"Feature Name" in "Set" Operation
"Feature Name" in "Unset" Operation
"Feature Name" in "Move" Operation
"Feature Name" in "Feature Column" Mapping in a Table Description

Comment 1 Etienne Juliot

2016-03-15 06:53:09 EDT

For information, I received some feedback from users at EclipseCon NA 2016 who complains about this lake of completion on these fields.

Comment 2 Eclipse Genie

2016-04-25 08:20:57 EDT

New Gerrit change created: https://git.eclipse.org/r/71322

Comment 3 Pierre-Charles David

2016-04-25 08:25:04 EDT

I've just pushed a draft at https://git.eclipse.org/r/71322, which simply changes the color (no other changes like completion or validation). The result looks like this: https://imgur.com/a/mDmv9

Note that this does not mean we've actually started work on this, but the color change itself is so trivial that I've pushed the patch for reference when we actually work on this. The more complicated thing will probably be to get everyone to agree on the color to use...

For completion, note that we should already have most of the actual code, as it should be very close to completion on feature: expressions (except that 'feature:' understand a few special pseudo-features).

Comment 4 Eclipse Genie

2017-03-24 06:18:59 EDT

New Gerrit change created: https://git.eclipse.org/r/93792

Comment 5 Florian Barbin

2017-05-12 09:27:08 EDT

*** Bug 447471 has been marked as a duplicate of this bug. ***

Comment 6 Eclipse Genie

2017-05-16 11:20:15 EDT

Gerrit change https://git.eclipse.org/r/93792 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=02f266cd9d0d5b83346755a8edc72f66a5ff8514

Comment 7 Cedric Brun

2017-05-17 09:26:54 EDT

The current (M7) behavior seems bogus, see the NodeCreation and ContainerCreation tools in EcoreTools for a reproduction case ( Datatype/Enumeration and Literal, Operation & Attribute)

Comment 8 Eclipse Genie

2017-05-18 09:35:39 EDT

New Gerrit change created: https://git.eclipse.org/r/97447

Comment 9 Eclipse Genie

2017-05-19 08:48:45 EDT

Gerrit change https://git.eclipse.org/r/97447 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d0c751786c8aaa67514c92c910984e501ce13e84

Comment 10 Pierre-Charles David

2017-05-19 10:19:44 EDT

The only thing left is to add some documentation in the "Specifier" part about these new fields.

Comment 11 Eclipse Genie

2017-05-19 11:11:18 EDT

New Gerrit change created: https://git.eclipse.org/r/97584

Comment 12 Eclipse Genie

2017-05-21 10:52:57 EDT

Gerrit change https://git.eclipse.org/r/97584 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=045818d87118f5a9f6dddce79df9d691ade270a8

Comment 13 Pierre-Charles David

2017-05-21 10:53:16 EDT

Fixed.

Comment 14 Laurent Redor

2017-05-22 09:11:52 EDT

Validated with ODCE 5.0.0 RC1 (Sirius 5.0.0.201705211502)

I noticed another improvment about completion and validation: bug 517073.

Comment 15 Eclipse Genie

2017-06-19 08:47:56 EDT

Gerrit change https://git.eclipse.org/r/98531 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a3746657f489fc257a9f614b41ff84c15adca44c

Comment 16 Pierre-Charles David

2017-06-29 03:31:51 EDT

Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.