Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 478802

Summary: "Reset style properties to default values" action is not always correct
Product: [Modeling] Sirius Reporter: Laurent Redor <laurent.redor>
Component: DiagramAssignee: Project Inbox <sirius.diagram-inbox>
Status: CLOSED FIXED QA Contact: Florian Barbin <florian.barbin>
Severity: normal    
Priority: P3 CC: florian.barbin, maxime.porhel
Version: 2.0.0Keywords: triaged
Target Milestone: 3.1.0   
Hardware: PC   
OS: All   
See Also: https://git.eclipse.org/r/57225
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2deaf1cd1024862d243cf6b3c484d7d6865ffca9
https://git.eclipse.org/r/57481
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=572a4c2346ae5d520e57cec3d209ee6e2e2b1742
https://git.eclipse.org/r/60221
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4280a8f7e4bcd9898ce74b5f532e4b8f0f9dc31c
https://git.eclipse.org/r/60464
https://git.eclipse.org/r/60465
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1365e37bdb3d4688cebab8db40022d51d1de0d6c
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b92065deecd131002f59cc21c86b23c7758bdfe6
Whiteboard: needtest
Bug Depends on:    
Bug Blocks: 470859    
Attachments:
Description Flags
CancelStyleProject.zip: For steps to reproduce none

Description Laurent Redor CLA 2015-10-01 08:20:48 EDT
Created attachment 256964 [details]
CancelStyleProject.zip: For steps to reproduce

When resetting the style from the appearance view, the result is not always as expected. But it is OK, for the same figure, with the same action from the tabbar.

Steps to reproduce:
* Import the project CancelStyleProject from CancelStyleProject.zip in your workspace
* Open the diagram "new MyDiagram"
* Set the font to bold for each 3 figures
* Select the diagram
* In the Properties view, in the Appearance tab, click on the "yellow arrow" button (Reset style properties to default values)
* The style is OK for the first node but KO for the two others.
* Save the diagram and reopen it.
* The style is now correctly reset.
Comment 1 Eclipse Genie CLA 2015-10-01 11:32:48 EDT
New Gerrit change created: https://git.eclipse.org/r/57225
Comment 3 Eclipse Genie CLA 2015-10-06 03:28:13 EDT
New Gerrit change created: https://git.eclipse.org/r/57481
Comment 4 Laurent Redor CLA 2015-10-06 03:31:09 EDT
The commit [1] fixes the problem. But this issue is not closed because it needs test. The gerrit [2] is a beginning of an adaptation of RefreshWithCustomizedStyleTests to launch these tests also from Appearance tab of Properties view (but it needs adaptation of method convertToSiriusPropertyValue for all properties).
Comment 6 Laurent Redor CLA 2015-10-09 04:18:10 EDT
Fixed in Sirius 3.1.0RC2 (test will be added later)
Comment 7 Florian Barbin CLA 2015-10-09 08:05:59 EDT
verified on Sirius 3.1.0.201510081411
Comment 8 Pierre-Charles David CLA 2015-10-16 09:09:48 EDT
Available in Sirius 3.1.0.
Comment 10 Eclipse Genie CLA 2015-11-12 09:44:53 EST
New Gerrit change created: https://git.eclipse.org/r/60221
Comment 12 Eclipse Genie CLA 2015-11-16 05:05:56 EST
New Gerrit change created: https://git.eclipse.org/r/60464
Comment 13 Eclipse Genie CLA 2015-11-16 05:08:20 EST
New Gerrit change created: https://git.eclipse.org/r/60465