Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 478400

Summary:	Add constraints for Fragments to allow their validation
Product:	[Eclipse Project] Platform	Reporter:	Jonas Helming <jhelming>
Component:	UI	Assignee:	Jonas Helming <jhelming>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, tom.schindl
Version:	4.5
Target Milestone:	4.6 M3
Hardware:	PC
OS:	Windows NT
See Also:	https://git.eclipse.org/r/57764 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=51236c1d101c390f286ecbcd46da649123b131bc
Whiteboard:
Bug Depends on:
Bug Blocks:	478399

Description Jonas Helming

2015-09-25 06:54:10 EDT

Currently, the model does not define any constraints, e.g. manditory values. For several purposes, it would be nice to define those constraints (in the ecore), e.g.:

- Checking fragments, before they get merged
- Providing validation in the e4 tools

I think adding those constraints should not have any side effects, if you do not trigger the validation.

What do you think?

Comment 1 Jonas Helming

2015-10-06 05:56:26 EDT

If there are no objections, I will go ahead and add constraints for the String fragment to fix Bug 478399

Comment 2 Eclipse Genie

2015-10-09 02:55:41 EDT

New Gerrit change created: https://git.eclipse.org/r/57764

Comment 3 Eclipse Genie

2015-10-09 06:15:44 EDT

Gerrit change https://git.eclipse.org/r/57764 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=51236c1d101c390f286ecbcd46da649123b131bc

Comment 4 Lars Vogel

2015-10-15 09:54:15 EDT

Jonas, did you forgot to mark this one as fixed?

Comment 5 Jonas Helming

2015-10-16 05:11:03 EDT

I have renamed it to the constraints I already added. I will open a new BR when we want to add other constraints. I named this BR in a generic way to draw attention to it for a general discussion, if we want to add constraints at all, but as nobody objected, we are fine...