Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 478050

Summary: [Default Theme] Make the selected part easily recognizable
Product: [Eclipse Project] Platform Reporter: Mickael Istria <mistria>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: enhancement    
Priority: P3 CC: daniel_megert, Lars.Vogel, loskutov, stephan.herrmann
Version: 4.5   
Target Milestone: ---   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/56418
https://bugs.eclipse.org/bugs/show_bug.cgi?id=325937
Whiteboard:
Attachments:
Description Flags
Comparison of reverted colors on tabs
none
White + 2 shades of grey
none
White + 2 shades of grey
none
activa part on extended_vs on eclipse 3.8 none

Description Mickael Istria CLA 2015-09-22 07:15:47 EDT
Created attachment 256750 [details]
Comparison of reverted colors on tabs

Currently, with the default theme (tested on Linux/GTK), the IDE is very bright, and the light/white is put on the part that don't have focus. This tends to make the UI too "aggressive" and doesn't help much in identifying which part has focus.

I suggest to invert the light of the parts, to show more "grey" (ie more inactive stuff in usual UI conventions of desktop applications) and to put the while/light on the selected part.
I tried it locally and found it better than the current status. See attachement for a comparison.
Comment 1 Eclipse Genie CLA 2015-09-22 07:18:54 EDT
New Gerrit change created: https://git.eclipse.org/r/56418
Comment 2 Lars Vogel CLA 2015-09-22 07:30:22 EDT
Can you add a screenshot "old" vs. "new"? side by side?
Comment 3 Mickael Istria CLA 2015-09-22 07:31:15 EDT
(In reply to Lars Vogel from comment #2)
> Can you add a screenshot "old" vs. "new"? side by side?

Have a look at the initial attachment ;)
Comment 4 Lars Vogel CLA 2015-09-22 07:34:49 EDT
(In reply to Lars Vogel from comment #2)
> Can you add a screenshot "old" vs. "new"? side by side?

Sorry, using a low resolution here, I see that you already did that.
Comment 5 Stephan Herrmann CLA 2015-09-22 07:45:08 EDT
You're entering the mine field of bug 325937 :)

Seriously: how am I to understand which tabs are selected / active?

Any theme that requires me to think about this question is a no go in terms of usability.
Comment 6 Stephan Herrmann CLA 2015-09-22 07:48:41 EDT
Let me try to be more specific: IMO the proposed theme improves the situation for views but makes it worse for editors: I get the impression that xs.class *may* be selected, but I don't really know just from looking at it.
Comment 7 Mickael Istria CLA 2015-09-22 07:49:20 EDT
(In reply to Stephan Herrmann from comment #5)
> Seriously: how am I to understand which tabs are selected / active?

With this proposal, the active part and its tabs get a lighter color (white), the selected tab has a kind of shadow on it.
The other unselected parts are grey and the selected tab is white.

Jeeyul's Chrome theme replaces the white active part by a blue one, and the active tab on that part is while. It's actually quite comfortable to use, but it introduces a newer color in the theme/workbench.
Comment 8 Mickael Istria CLA 2015-09-22 08:19:30 EDT
Created attachment 256751 [details]
White + 2 shades of grey

@Stephan: Here is a proposal that uses only white for the very active tab, and 2 shardes of grey for others
Comment 9 Mickael Istria CLA 2015-09-22 08:22:47 EDT
Created attachment 256753 [details]
White + 2 shades of grey

Replace attachment#2 [details] (which was missing an selected tab to show the white)
Comment 10 Andrey Loskutov CLA 2015-09-22 08:45:07 EDT
Created attachment 256754 [details]
activa part on extended_vs on eclipse 3.8

(In reply to Mickael Istria from comment #8)
> Created attachment 256751 [details]
> White + 2 shades of grey
> 
> @Stephan: Here is a proposal that uses only white for the very active tab,
> and 2 shardes of grey for others

I had to read the comments few times to get an idea which tab is selected finally for last screenshot (Git Staging???). Neither the default nor the proposal are working for me is I wear "stupid user" hat. Could you please post here the Jeeyul's Chrome theme screenshot, so that we have an idea how it could look like in a "better" IDE?

I'm still on 3.8 and with my own Extended VS presentation / color sheme I have pretty clear idea what is "current", see attached picture.

So if this helps, we should fix this bug and bug 325937 by introducing a clearly recognizable "active part" color which is NOT white NOR grey but something anyone can easily identify - might be "lighter" eclipse blue color.
Comment 11 Andrey Loskutov CLA 2015-09-22 08:48:56 EDT
Isn't this actually a real duplicate of a bug 325937?
Comment 12 Lars Vogel CLA 2015-09-22 08:54:40 EDT
(In reply to Andrey Loskutov from comment #11)
> Isn't this actually a real duplicate of a bug 325937?

+1
Comment 13 Mickael Istria CLA 2015-09-22 09:04:31 EDT

*** This bug has been marked as a duplicate of bug 325937 ***