Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 477277

Summary:	Follow-up button results in 500 Internal server error
Product:	Community	Reporter:	Marc-André Laperle <malaperle>
Component:	Gerrit	Assignee:	Eclipse Webmaster <webmaster>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	denis.roy
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:	stalebug

Description Marc-André Laperle

2015-09-13 15:05:46 EDT

In this review:
https://git.eclipse.org/r/#/c/55160

I clicked on the Follow-up button and I get
"500 Internal server error"

I just wanted to try this new Gerrit feature and understand how it works but it doesn't seem to work. Something wrong in our project config or the server?

Comment 1 Denis Roy

2015-09-14 08:58:54 EDT

This is the stack trace I get in the error log... Not sure what it means:

[2015-09-14 08:57:10,446] ERROR com.google.gerrit.httpd.restapi.RestApiServlet : Error in POST /r/changes/
com.google.gerrit.server.project.InvalidChangeOperationException: not Signed-off-by author/committer/uploader in commit message footer
        at com.google.gerrit.server.change.CreateChange.validateCommit(CreateChange.java:240)
        at com.google.gerrit.server.change.CreateChange.apply(CreateChange.java:210)
        at com.google.gerrit.server.change.CreateChange.apply(CreateChange.java:76)
        at com.google.gerrit.httpd.restapi.RestApiServlet.service(RestApiServlet.java:322)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
        at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:279)
        at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:269)
        at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:180)
        at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)
        at com.google.gerrit.httpd.GetUserFilter.doFilter(GetUserFilter.java:82)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gwtexpui.server.CacheControlFilter.doFilter(CacheControlFilter.java:73)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gerrit.httpd.RunAsFilter.doFilter(RunAsFilter.java:117)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gerrit.httpd.RequireSslFilter.doFilter(RequireSslFilter.java:68)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:64)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:57)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:75)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:119)
        at com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:133)
        at com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:130)
        at com.google.inject.servlet.GuiceFilter$Context.call(GuiceFilter.java:203)
        at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:130)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
        at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
        at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:221)
        at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
        at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
        at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
        at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
        at org.eclipse.jetty.server.Server.handle(Server.java:497)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
        at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
        at java.lang.Thread.run(Thread.java:795)

Comment 2 Marc-André Laperle

2015-09-14 09:31:49 EDT

Interesting, I had to put the signed-off in the commit message for it to go through. It must be because or the project setting "Require Signed-off-by in commit message"
i.e.:
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Maybe a bug in Gerrit itself. I'll check if something like that is already reported.

Comment 3 Marc-André Laperle

2015-09-15 17:46:18 EDT

https://code.google.com/p/gerrit/issues/detail?id=3563

Comment 4 Eclipse Genie

2017-09-05 16:41:37 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 5 Eclipse Webmaster

2018-01-17 10:35:33 EST

Marc is this still an issue?

-M.