Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 477049

Summary:	Improve edge interactions on Regions/RegionContainers
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Diagram	Assignee:	Maxime Porhel <maxime.porhel>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	florian.barbin, laurent.fasani
Version:	2.0.5	Keywords:	triaged
Target Milestone:	3.1.0
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/55643 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c519ba977db3dc4fb31e1270883cabb4e650b2e6
Whiteboard:	needtest
Bug Depends on:
Bug Blocks:	470859

Description Maxime Porhel

2015-09-10 06:00:27 EDT

ReconnectEdgeDescription tool do not have extra source/target mapping, so if there is a   Reconnect tool on an edge with a RegionContainer source/target mapping, the user will be able to reconnect only to the RegionContainer title area if the label is not hidden.  Furthermore, if the mouse hovers one of the regions, he will see the forbidden feedback. 

EdgeCreationDescription allows extra source and target mapping, if the specifier uses them, it allows to avoid the forbidden feedback, but the creation feedback is on the Region when the mouse hovers the region and on the RegionContainer only when the mouse hovers the title area.

Comment 1 Maxime Porhel

2015-09-10 08:09:48 EDT

The idea here is to: 
 . delegate the edge creation to the RegionContainer if the hovered Region do not propose an executable command (see getConnectionCreateCommand() and getConnectionCompleteCommand()).
 . disable the reconnection on the Region to always delegate the reconnect to the RegionContainer. 


In a further bugzilla, when the ReconnectToolDescription will allow extra source/target mappings, we will be able t handle the reconnect on Region.

Comment 2 Eclipse Genie

2015-09-10 08:37:36 EDT

New Gerrit change created: https://git.eclipse.org/r/55643

Comment 3 Eclipse Genie

2015-09-11 05:57:57 EDT

Gerrit change https://git.eclipse.org/r/55643 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c519ba977db3dc4fb31e1270883cabb4e650b2e6

Comment 4 Maxime Porhel

2015-10-13 09:42:37 EDT

Can be validated with ecore tools draft 
- checkout https://git.eclipse.org/r/#/c/55419/
- EdgeCreationTools: 
    - SuperType: compartment as extra source mapping: creation feedback on regions and/or title area
    - Other edges tools: feedback on the RegionContainer: creation feedback on the RegionContainer
- Reconnection tests with super types edges: feedback on the RegionContainer



The edge creation is delegated to the RegionContainer if no tool is found for a Region (compartment) (see feedback)

The reconnection is only possible on RegionContainer mapping (warning validation rule in the VSM editor)

Comment 5 Florian Barbin

2015-10-15 04:19:28 EDT

Verified on current Sirius master with ecoretools patch set.

Comment 6 Pierre-Charles David

2015-10-16 09:10:27 EDT

Available in Sirius 3.1.0.