Bugzilla – Full Text Bug Listing
| Summary: | Create eclipse.platform.ui/bundles/pom.xml for Eclipse bundles to allow building them as one unit | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | daniel_megert, david_williams, Lars.Vogel, mistria |
| Version: | 3.7.1 | ||
| Target Milestone: | 4.7 M6 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/57942 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a179c98c01b149d6225137408f7dc66300ec9949 https://git.eclipse.org/r/58282 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=394aef3616dd143eea9558da1ecdd6932118109c https://git.eclipse.org/r/90364 https://git.eclipse.org/r/90367 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6d8ed5b104fa85428c5060335d2861aa7870f826 |
||
| Whiteboard: | |||
|
Description
Lars Vogel
Adding David, in case this change breaks the aggregator build. platform.ui build works fine with that so I assume not. But you never know.. Gerrit change https://git.eclipse.org/r/57942 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a179c98c01b149d6225137408f7dc66300ec9949 . How's your local, complete build coming, Lars?
This change causes mine to fail miserably.
At first I was going to ask you to revert the changes in the repo pom, since when I tried that, my local build succeeds.
But looking a little closer, your pom in your <bundles> module is all messed up. Looks like a "double paste"? I do not know if fixing that, would fix the build -- and if I may be blunt, I really do not have time to chase down build problems caused by changes like this. Please confirm it builds before you commit. And, if you can not do that, then please don't commit it.
Plus, any pom you plan on "building individually" must have this magic section in it (I'm fairly sure).
<!--
To build individual bundles, we specify a repository where to find parent pom,
in case it is not in local maven cache already
and that parent pom also has fuller individual-bundle profile
defined that is combined with this one. -->
<profiles>
<profile>
<id>build-individual-bundles</id>
<repositories>
<repository>
<releases>
<enabled>true</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
<id>eclipse-hosted</id>
<url>https://repo.eclipse.org/content/repositories/eclipse/</url>
</repository>
</repositories>
</profile>
</profiles>
Honestly, I do not know what motivates this change. You say to "build individually" in the title, but that should already be possible, right?
If not, I think something else is wrong.
If you just meant to "build individually faster", then that might be true, but, not sure it'd be much of a practical difference. Do you know?
= = = = wordy section ahead = = = = =
To highlight the magnitude of this problem ... I have as of now spent about 6 hours tracking it down, instead of spending 6 hours on any of the many other things I was hoping to get done today. All of which needed a local working build. Makes me feel discouraged.
I know, mistakes happen, but ... lately, it seems I am spending a lot of my time chasing down other people's problems due to dubious changes, which could have been avoided with a little more diligence or running a complete local build, as was kindly documented for us in
https://wiki.eclipse.org/Platform-releng/Platform_Build.
The double paste even shows up with red X's in my dev. environment. I assume XML validation errors, so that would have been easy to avoid committing (but, again, I do not know if that really solves the problem ... maybe, but have not tried that.
I in no way intend this as a criticism. More of a "life lesson". :) Subtle difference, but I would feel remiss if I didn't point out the consequences of errors such as this one. I hope I'm being constructive, that's my intent. ]
New Gerrit change created: https://git.eclipse.org/r/58282 Gerrit change https://git.eclipse.org/r/58282 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=394aef3616dd143eea9558da1ecdd6932118109c (In reply to David Williams from comment #4) > Please confirm it builds before > you commit. And, if you can not do that, then please don't commit it. Sorry, I trusted the Gerrit build validation job, which confirmed to me that this change works fine. > > = = = = wordy section ahead = = = = = > > To highlight the magnitude of this problem ... I have as of now spent about > 6 hours tracking it down, instead of spending 6 hours on any of the many > other things I was hoping to get done today. All of which needed a local > working build. Makes me feel discouraged. Sorry, again. I assumed the Gerrit build trigger should catch this. It uses the normal Tycho build steps, e.g., clean verify. If there is something in this build setup which is different from your setup, we should definitely fix that. > I in no way intend this as a criticism. More of a "life lesson". :) Subtle > difference, but I would feel remiss if I didn't point out the consequences > of errors such as this one. I hope I'm being constructive, that's my intent. > ] I definitely have to learn more about the build and how the real build differs from Gerrit and why Gerrit did not catch this. That was also the reason why I send you a request about an information sharing about the build and the Gerrit build a few weeks ago. (In reply to Eclipse Genie from comment #6) > Gerrit change https://git.eclipse.org/r/58282 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=394aef3616dd143eea9558da1ecdd6932118109c I reverted the commit. (In reply to Lars Vogel from comment #8) Opened Bug 476726 for the investigation between the difference of a local build and our Gerrit build trigger. (In reply to Lars Vogel from comment #9) > Opened Bug 476726 for the investigation between the difference of a local > build and our Gerrit build trigger. s/Bug 476726/Bug 479894. I did some more experiments with this, using the procedure so kindly documented for us in https://wiki.eclipse.org/Platform-releng/Platform_Build Other than the issues I have already mentioned, the MAIN problem is that in some of your pom refactoring, the feature was completely omitted. That is, the line that says <module>features/org.eclipse.e4.rcp</module> was nowhere to be found. BUT, you never did answer my question about why you were making this change. I'd like to hear that reasoning before any changes are made here. If there's not a substantial reason, seems it would be closed as "won't fix". Again, the only hint of a reason was "to build individual bundles" but as far as I know, that is already possible, right? Mass move to 4.6 RC1. We might push out more to 4.7. As this is not high priority, let's target it for next version and move it back to 4.6.RCx if it becomes high priority before 4.6 release. New Gerrit change created: https://git.eclipse.org/r/90364 New Gerrit change created: https://git.eclipse.org/r/90367 Gerrit change https://git.eclipse.org/r/90367 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6d8ed5b104fa85428c5060335d2861aa7870f826 |