Bugzilla – Full Text Bug Listing
|
Description
Lars Vogel
Related to bug 291518. Stefan, can you take this bug? I see still lots of usage of SubProgressMonitor in platform.ui. Sure. Working on it now. I'll submit one commit per package in order to break down the scope of the change. While I'm at it, I'll also fix any progress-reporting bugs I come across and remove workarounds for bugs in SubProgressMonitor (such as the common "multiply progress by 1000" trick that was commonly used to work around the SPM resolution bug). I may need some help with testing. New Gerrit change created: https://git.eclipse.org/r/55894 New Gerrit change created: https://git.eclipse.org/r/55909 New Gerrit change created: https://git.eclipse.org/r/55910 New Gerrit change created: https://git.eclipse.org/r/55911 New Gerrit change created: https://git.eclipse.org/r/55912 New Gerrit change created: https://git.eclipse.org/r/55913 New Gerrit change created: https://git.eclipse.org/r/55915 New Gerrit change created: https://git.eclipse.org/r/55916 New Gerrit change created: https://git.eclipse.org/r/55917 New Gerrit change created: https://git.eclipse.org/r/55918 There we go. These patches remove every reference I could find to SubProgressMonitor in the eclipse.platform.ui repository. I wrote them using visual inspection and confirmed that they compile, but have not tested them yet (and I'm not entirely sure how to reach all those branches). I'll try to test them all tomorrow, but may need help with some of the more obscure branches. They could also use some additional eyes on them, so if you have time I'd appreciate if you could look over one or two of them. Also, if you could help me test a couple of them it would be greatly appreciated. Just let me know which ones you've verified so I don't repeat any work. Gerrit change https://git.eclipse.org/r/55909 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ea9d71a488dcd539b8b3a84d7ddc8b2acbca7bf5 Gerrit change https://git.eclipse.org/r/55911 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ab0a4e07b8b5102fa2756c32111cd2d6d7ce13e2 Gerrit change https://git.eclipse.org/r/55912 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2daab974129378b92daacc860dbcee77dabf2123 Gerrit change https://git.eclipse.org/r/55910 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b071a5aa0e1dbef1760839ea0a8abe805a6d8830 Gerrit change https://git.eclipse.org/r/55917 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5957cef476205f372aa1ad15a8798bb2254a87ed Gerrit change https://git.eclipse.org/r/55918 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9030b39b10c8df7a53aacb45437b92be765b8566 Gerrit change https://git.eclipse.org/r/55894 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e1fb21c161e6f9188ad46cb4aebf2c4a6984f90c Gerrit change https://git.eclipse.org/r/55913 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d7a1117af7376fa32af298daeb4065bfcd631551 Gerrit change https://git.eclipse.org/r/55915 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9468f370adbfd4af0d76c4ec6e6c22edb43162e4 Gerrit change https://git.eclipse.org/r/55916 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=85b93c1e2053aa36564fe96be16b502e1944b683 All changes merged. SubMonitor has been purged from platform UI. Now to get rid of manual GridLayout instantiation in favor of GridLayoutFactory, eleminate the use of ImageRegistry, FontRegistry, and friends, update our Jobs to use lambdas... Stefan, we're in the M2 week. No regular changes must be released until M2 is declared. Please revert this immediately. . (In reply to Markus Keller from comment #26) > Stefan, we're in the M2 week. No regular changes must be released until M2 > is declared. Please revert this immediately. Please revert it with one commit. We discussed this in the status call. Since we're not sure in which time zone Stefan is, I'll do the revert. Reverted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=29da1e2b77a857c43a558eafcc528e5717b1e321 This commit can be reverted again and pushed after M2 is declared. Yeah, my bad. Reverting was the right thing to do. New Gerrit change created: https://git.eclipse.org/r/56271 Gerrit change https://git.eclipse.org/r/56271 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b51d6dfc180ca7cdf065958541f51484c2e036d9 Reverted the revert. Re-closing. New Gerrit change created: https://git.eclipse.org/r/56273 Gerrit change https://git.eclipse.org/r/56273 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c7a4a91a8f6f6a9c5d4dae92ac80eda4645b80db (In reply to Eclipse Genie from comment #36) > Gerrit change https://git.eclipse.org/r/56273 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=c7a4a91a8f6f6a9c5d4dae92ac80eda4645b80db I think you missed a monitor.done removal. See Gerrit reviwe New Gerrit change created: https://git.eclipse.org/r/56450 Gerrit change https://git.eclipse.org/r/56450 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fcadf18bbe1e72f5f6eddfd3ea6f47fb854028f9 > I think you missed a monitor.done removal. See Gerrit reviwe
Done.
You have to specify a comment when changing the Status of a bug from REOPENED to RESOLVED. The changes made in OpenResourceAction cause a bad regression, see bug 510537. |