Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 475775

Summary:	ExternalBrowserInstance now test for the return value which is for us 1 for Internet Explorer
Product:	[Eclipse Project] Platform	Reporter:	Johan Compagner <jcompagner>
Component:	UI	Assignee:	Brian de Alwis <bsd>
Status:	VERIFIED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	bsd, Lars.Vogel, ssw
Version:	4.5
Target Milestone:	4.6 M5
Hardware:	PC
OS:	Windows NT
See Also:	https://git.eclipse.org/r/64910 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a5c2de2fb78071d24a77b1ffc7c945cd095a08ee https://bugs.eclipse.org/bugs/show_bug.cgi?id=463949
Whiteboard:

Description Johan Compagner

2015-08-25 05:36:47 EDT

this change: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/ExternalBrowserInstance.java?id=78cb5dc8ea5ef47b5e38ae532f62bc0dafaeec5c

now test for the process.exitvalue

and if that is not 0 it always just pops up a dialog 

But the thing is that the launching did go fine, the url was shown fine, the only thing we did was close the browser or tab and we get always that error in eclipse that the browser did not launch correctly.

Comment 1 Johan Compagner

2015-08-25 05:55:24 EDT

this only reproduces if you really don't have an IE running at all

If you then close IE right after you launch it it will give you exitCode == 1
if an existing IE is already there and you launch something (in another window) and close that only only (leave the other one running) then it works fine then the exit code == 0

Comment 2 Brian de Alwis

2015-08-26 16:13:32 EDT

Gosh, that's helpful behaviour from IE.

Comment 3 Eclipse Genie

2016-01-21 13:50:26 EST

New Gerrit change created: https://git.eclipse.org/r/64910

Comment 4 Eclipse Genie

2016-01-21 15:49:36 EST

Gerrit change https://git.eclipse.org/r/64910 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a5c2de2fb78071d24a77b1ffc7c945cd095a08ee

Comment 5 Brian de Alwis

2016-01-21 15:52:41 EST

Fixed for 4.6M5

Comment 6 Brian de Alwis

2016-01-25 15:11:32 EST

Verified in 4.6.0.I20160125-0400

Comment 7 Brian de Alwis

2016-02-23 12:04:38 EST

*** Bug 488242 has been marked as a duplicate of this bug. ***