Bug 475580

Comment 1 Esteban DUGUEPEROUX 2015-08-21 07:57:36 EDT

Scenario to reproduce :

1. Import the attached projet
2. Open the odesign and select the first Variable Filter
3. In the semantic candidates expession test AQL completion between last brackets, i.e. in ->collect() => KO

Comment 2 Esteban DUGUEPEROUX 2015-08-21 08:34:39 EDT

Another AQL completion issue with the attached sample project but now with the interpreter view from Acceleo :

1. Set focus on the diagram in the sample,
2. Use Sirius interpreter mode instead of Acceleo default one,
3. Start from "aql:self.target." expression, and Ctrl+Space type "eAll" to have "eAllContents" proposed, type Esc to remove completion and Ctrl+Space again to have completion and select "eAllContents" again =>KO "aql:self.target.eAlleAllContents()" is set as expression instead of "aql:self.target.eAllContents()"

Comment 3 Esteban DUGUEPEROUX 2015-08-21 11:28:01 EDT

With the same project sample, with diagram in context, an expression to retreive "newEClass1" :
- with A3 it works :  [self.target.eAllContents()->select(oclIsKindOf(ecore::ENamedElement))->select(oclAsType(ecore::ENamedElement).name='newEClass1')/]

- but with AQL, if I write "aql:self.target.eAllContents()->select(name='newEClass1')" it is displayed "1 error detected" and AcceleoQueryEvaluationException in tooltip

But it seems that a more correct AQL expression would be :

aql:self.target.eAllContents()->select(c : EClass | c.name='newEClass1')

which is correctly evaluated in interpreter view but in odesign the validation show error with it. Under first diagram description, creates a filter with a variable filter then in the "semantic candidates expression" set "aql:self.target.eAllContents()->select(c : EClass | c.name='newEClass1')" and launch validation. 3 errors markers are created :

- Twice "Attempt to access feature (target) on a non ModelObject value (interface org.eclipse.emf.ecore.EObject)."
- And "The c variable has no types"


If I try with "aql:self.oclAsType(viewpoint::DSemanticDecorator).target.eAllContents(ecore::EClass)->select(c : ecore::EClass | c.name='newEClass2')" I have "ErrorTypeLiteral" error marker in addition.

Comment 4 Cedric Brun 2015-09-10 05:27:07 EDT

(In reply to Esteban DUGUEPEROUX from comment #1)
> Scenario to reproduce :
> 
> 1. Import the attached projet
> 2. Open the odesign and select the first Variable Filter
> 3. In the semantic candidates expession test AQL completion between last
> brackets, i.e. in ->collect() => KO

This is still true with org.acceleo.query-3.6.1.20150902

Comment 5 Cedric Brun 2015-09-10 05:33:10 EDT

(In reply to Esteban DUGUEPEROUX from comment #1)
> Scenario to reproduce :
> 
> 1. Import the attached projet
> 2. Open the odesign and select the first Variable Filter
> 3. In the semantic candidates expession test AQL completion between last
> brackets, i.e. in ->collect() => KO

This is still true with org.acceleo.query-3.6.1.20150902(In reply to Esteban DUGUEPEROUX from comment #2)
> Another AQL completion issue with the attached sample project but now with
> the interpreter view from Acceleo :
> 
> 1. Set focus on the diagram in the sample,
> 2. Use Sirius interpreter mode instead of Acceleo default one,
> 3. Start from "aql:self.target." expression, and Ctrl+Space type "eAll" to
> have "eAllContents" proposed, type Esc to remove completion and Ctrl+Space
> again to have completion and select "eAllContents" again =>KO
> "aql:self.target.eAlleAllContents()" is set as expression instead of
> "aql:self.target.eAllContents()"

This one is fixed with Sirius 3.1 and org.acceleo.query-3.6.1.20150902

Comment 6 Cedric Brun 2015-09-10 05:34:05 EDT

Sorry, comments mangling this issue : 

> > Another AQL completion issue with the attached sample project but now with
> > the interpreter view from Acceleo :
> > 
> > 1. Set focus on the diagram in the sample,
> > 2. Use Sirius interpreter mode instead of Acceleo default one,
> > 3. Start from "aql:self.target." expression, and Ctrl+Space type "eAll" to
> > have "eAllContents" proposed, type Esc to remove completion and Ctrl+Space
> > again to have completion and select "eAllContents" again =>KO
> > "aql:self.target.eAlleAllContents()" is set as expression instead of
> > "aql:self.target.eAllContents()"
> 

is fixed with Sirius 3.1 and org.acceleo.query-3.6.1.20150902

Comment 7 Cedric Brun 2015-09-10 05:41:07 EDT

> which is correctly evaluated in interpreter view but in odesign the
> validation show error with it. Under first diagram description, creates a
> filter with a variable filter then in the "semantic candidates expression"
> set "aql:self.target.eAllContents()->select(c : EClass |
> c.name='newEClass1')" and launch validation. 3 errors markers are created :
> 
> - Twice "Attempt to access feature (target) on a non ModelObject value
> (interface org.eclipse.emf.ecore.EObject)."
> - And "The c variable has no types"

With org.acceleo.query-3.6.1.20150902 I only get one error: which is "attempt to access feature "target" on a non model object value which is expected as the "self" variable only has the EObject type. 


> 
> 
> If I try with
> "aql:self.oclAsType(viewpoint::DSemanticDecorator).target.eAllContents(ecore:
> :EClass)->select(c : ecore::EClass | c.name='newEClass2')" I have
> "ErrorTypeLiteral" error marker in addition.

Also fixed with org.acceleo.query-3.6.1.20150902, no error is triggered anymore.

Comment 8 Cedric Brun 2015-09-10 05:43:07 EDT

All in all, only one issue remain which is the classcast and lack of completion mentionned in https://bugs.eclipse.org/bugs/show_bug.cgi?id=475580#c1

java.lang.ClassCastException: org.eclipse.acceleo.query.validation.type.NothingType cannot be cast to org.eclipse.acceleo.query.validation.type.EClassifierType
	at org.eclipse.acceleo.query.runtime.impl.completion.VariableDeclarationCompletionProposal.getProposal(VariableDeclarationCompletionProposal.java:58)
	at org.eclipse.acceleo.query.runtime.impl.BasicFilter.keepProposal(BasicFilter.java:48)
	at org.eclipse.acceleo.query.runtime.impl.CompletionResult.getProposals(CompletionResult.java:66)
	at org.eclipse.sirius.common.acceleo.aql.ide.proposal.AQLProposalProvider.getProposals(AQLProposalProvider.java:106)
	at org.eclipse.sirius.common.acceleo.aql.ide.proposal.AQLProposalProvider.getProposals(AQLProposalProvider.java:76)
	at org.eclipse.sirius.common.tools.api.interpreter.CompoundInterpreter.getProposals(CompoundInterpreter.java:836)
	at org.eclipse.sirius.ui.tools.api.assist.TextContentProposalProvider.getProposals(TextContentProposalProvider.java:88)
	at org.eclipse.jface.fieldassist.ContentProposalAdapter.getProposals(ContentProposalAdapter.java:2038)
	at org.eclipse.jface.fieldassist.ContentProposalAdapter.openProposalPopup(ContentProposalAdapter.java:1882)
	at org.eclipse.jface.fieldassist.ContentProposalAdapter.access$16(ContentProposalAdapter.java:1877)
	at org.eclipse.jface.fieldassist.ContentProposalAdapter$1.handleEvent(ContentProposalAdapter.java:1748)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)

Comment 9 Laurent Goubet 2015-09-11 05:01:54 EDT

This bug stems from Sirius itself, specifically from:
org.eclipse.sirius.common.acceleo.aql.business.api.org.eclipse.sirius.common.acceleo.aql.business.api(IInterpreterContext, IQueryEnvironment)

When calling for the completion at the location outlined by Esteban in comment #1, we go through the above method with nothing in our interpreter context, not even a typing for "self".

In such a case, it will do (at line 62) :

        if (selfTyping.size() == 0) {
            selfTyping.add(new ClassType(queryEnvironment, EObject.class));
        }

But "ClassType" is for Java Classes, not for model Classes. This should have been

        if (selfTyping.size() == 0) {
            selfTyping.add(new EClassifierType(queryEnvironment, EcorePackage.eINSTANCE.getEObject()));
        }

Comment 10 Eclipse Genie 2015-09-11 05:14:27 EDT

New Gerrit change created: https://git.eclipse.org/r/55717

Comment 11 Eclipse Genie 2015-09-11 11:15:04 EDT

Gerrit change https://git.eclipse.org/r/55717 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=69251eb1f7e70c532bdb25e0181d7ff28a994ca4

Comment 12 Pierre-Charles David 2015-09-15 10:00:19 EDT

I now get a different CCE from JFace, with Esteban's scenario on current master (with http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=69251eb1f7e70c532bdb25e0181d7ff28a994ca4 merged):

java.lang.ClassCastException: org.eclipse.jface.viewers.StructuredSelection cannot be cast to org.eclipse.jface.viewers.TreeSelection
	at org.eclipse.sirius.ui.tools.api.assist.TextContentProposalProvider.getSelectedElement(TextContentProposalProvider.java:109)
	at org.eclipse.sirius.ui.tools.api.assist.TextContentProposalProvider.getContentContext(TextContentProposalProvider.java:100)
	at org.eclipse.sirius.ui.tools.api.assist.TextContentProposalProvider.getProposals(TextContentProposalProvider.java:80)
	at org.eclipse.jface.fieldassist.ContentProposalAdapter.getProposals(ContentProposalAdapter.java:2057)
	at org.eclipse.jface.fieldassist.ContentProposalAdapter.openProposalPopup(ContentProposalAdapter.java:1903)
	at org.eclipse.jface.fieldassist.ContentProposalAdapter.access$16(ContentProposalAdapter.java:1898)
	at org.eclipse.jface.fieldassist.ContentProposalAdapter$1.handleEvent(ContentProposalAdapter.java:1769)

Comment 13 Eclipse Genie 2015-09-15 10:10:41 EDT

New Gerrit change created: https://git.eclipse.org/r/55982

Comment 14 Pierre-Charles David 2015-09-15 10:12:36 EDT

With
  https://git.eclipse.org/r/55982 [475580] Avoid CCE in interpreted expression completion
the original scenario seems to work. The completion popup is a little slow to appear (the first time), but at least it appears, with no error in the error log. It offers a single proposal: "eObjects : ecore::EObject | ", which seems fine given the context.

Comment 15 Eclipse Genie 2015-09-15 11:51:29 EDT

Gerrit change https://git.eclipse.org/r/55982 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2636f0a664aeeab9fed648c52fae8100a8bc95a7

Comment 16 Pierre-Charles David 2015-09-15 11:52:14 EDT

Secondary failure fixed by 2636f0a664aeeab9fed648c52fae8100a8bc95a7.

Comment 17 Jessy Mallet 2015-09-29 05:16:53 EDT

Validated with Sirius 3.1.0.201509241504

Comment 18 Pierre-Charles David 2015-10-16 09:11:44 EDT

Available in Sirius 3.1.0.