Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 475553

Summary: AbstractPolicy#disableRefreshVisuals() does not change the parts refreshVisual state.
Product: [Tools] GEF Reporter: Alexander Nyßen <nyssen>
Component: GEF MVCAssignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.1.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Alexander Nyßen CLA 2015-08-21 01:07:34 EDT 

    


    


      



        
          Comment 1
        

        
          Alexander Nyßen CLA

        

        
        

        
          2015-08-21 01:19:55 EDT
        

      






AbstractPolicy#disableRefreshVisuals() does not set the refreshVisual state of the given part, even if the name of the operation implies this, while enableRefreshVisual() sets the state. We should ensure that disableRefreshVisuals() really disables the refresh state. 

Furthermore, the name of enableRefreshVisuals() does not seem appropriate, as it will simply restore the refreshVisual state that was captured by disableRefreshVisual(). As such, we should rename both operations to properly indicate that a state is persistent and restored, e.g. into storeAndDisableRefreshVisual() and restoreRefreshVisual()

    


    


      



        
          Comment 2
        

        
          Alexander Nyßen CLA

        

        
        

        
          2015-08-21 05:47:15 EDT
        

      






Fixed that #disableRefreshVisuals() did not affect the refreshVisual state of the given part. Adopted FXRelocateOnDragPolicy to rely on this new behavior. Resolving as fixed in 3.10.1 RC2.