Bug 475535

Description Melina Mongiovi 2015-08-20 17:34:39 EDT

Applying the encapsulate field refactoring in the field A.f, the transformation replaces the field assignment f = 10 in the A constructor by the set method setF(10).

When you are using self-encapsulation you have to be careful about using the setting method in the constructor. Often it is assumed that you use the setting method for changes after the object is created, so you may have different behavior in the setter than you have when initializing.

Before Refactoring:

public class A {
    private int f;    
    public A() {
        f = 10;
    }
    int m(int x) {
        return f;
    }
}

Resulting program:

public class A {
    private int f;    
    public A() {
        setF(10);
    }
    int m(int x) {
        return getF();
    }
	private int getF() {
		return f;
	}
	private void setF(int f) {
		this.f = f;
	}
}