Bugzilla – Full Text Bug Listing
| Summary: | Data race on org.eclipse.jdt.internal.core.JavaProjectElementInfo.projectCache | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Yilong Li <yilong.li> |
| Component: | Core | Assignee: | JDT-Core-Inbox <jdt-core-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | stephan.herrmann |
| Version: | 4.6 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
New Gerrit change created: https://git.eclipse.org/r/56034 This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
Here is the race report given by a dynamic race detector: Data race on field org.eclipse.jdt.internal.core.JavaProjectElementInfo.projectCache: {{{ Concurrent read in thread T29 (locks held: {}) ----> at org.eclipse.jdt.internal.core.JavaModelManager.determineIfOnClasspath(JavaModelManager.java:1033) at org.eclipse.jdt.internal.core.JavaModelManager.createCompilationUnitFrom(JavaModelManager.java:979) at org.eclipse.jdt.internal.core.JavaModelManager.secondaryTypeAdding(JavaModelManager.java:4480) at org.eclipse.jdt.internal.core.search.indexing.AbstractIndexer.addTypeDeclaration(AbstractIndexer.java:186) at org.eclipse.jdt.internal.core.search.indexing.AbstractIndexer.addClassDeclaration(AbstractIndexer.java:47) at org.eclipse.jdt.internal.core.search.indexing.SourceIndexerRequestor.enterClass(SourceIndexerRequestor.java:215) at org.eclipse.jdt.internal.core.search.indexing.SourceIndexerRequestor.enterType(SourceIndexerRequestor.java:314) at org.eclipse.jdt.internal.compiler.SourceElementNotifier.notifySourceElementRequestor(SourceElementNotifier.java:635) at org.eclipse.jdt.internal.compiler.SourceElementNotifier.notifySourceElementRequestor(SourceElementNotifier.java:457) at org.eclipse.jdt.internal.compiler.SourceElementParser.parseCompilationUnit(SourceElementParser.java:967) at org.eclipse.jdt.internal.core.search.indexing.SourceIndexer.indexDocument(SourceIndexer.java:108) at org.eclipse.jdt.internal.core.search.JavaSearchParticipant.indexDocument(JavaSearchParticipant.java:76) at org.eclipse.jdt.internal.core.search.indexing.IndexManager.indexDocument(IndexManager.java:504) at org.eclipse.jdt.internal.core.search.indexing.IndexManager$1.execute(IndexManager.java:984) at org.eclipse.jdt.internal.core.search.processing.JobManager.run(JobManager.java:405) T29 is created by T1 at org.eclipse.jdt.internal.core.search.processing.JobManager.reset(JobManager.java:331) Concurrent write in thread T1 (locks held: {}) ----> at org.eclipse.jdt.internal.core.JavaProjectElementInfo.getProjectCache(JavaProjectElementInfo.java:232) at org.eclipse.jdt.internal.core.JavaProjectElementInfo.newNameLookup(JavaProjectElementInfo.java:291) at org.eclipse.jdt.internal.core.JavaProject.newNameLookup(JavaProject.java:2329) at org.eclipse.jdt.internal.core.JavaProject.newNameLookup(JavaProject.java:2339) at org.eclipse.jdt.internal.core.JavaProject.findType(JavaProject.java:1357) at org.eclipse.jdt.internal.core.JavaProject.findType(JavaProject.java:1264) at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.acceptResult(AbstractImageBuilder.java:170) at org.eclipse.jdt.internal.compiler.Compiler$1.acceptResult(Compiler.java:280) at org.eclipse.jdt.internal.compiler.Compiler.processCompiledUnits(Compiler.java:589) at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:458) at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile(AbstractImageBuilder.java:367) at org.eclipse.jdt.internal.core.builder.IncrementalImageBuilder.compile(IncrementalImageBuilder.java:330) at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile(AbstractImageBuilder.java:304) at org.eclipse.jdt.internal.core.builder.IncrementalImageBuilder.build(IncrementalImageBuilder.java:135) at org.eclipse.jdt.internal.core.builder.JavaBuilder.buildDeltas(JavaBuilder.java:267) at org.eclipse.jdt.internal.core.builder.JavaBuilder.build(JavaBuilder.java:195) at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:735) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:206) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:246) at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:301) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:304) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:263) at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:403) at org.eclipse.core.internal.resources.Project$1.run(Project.java:557) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2242) at org.eclipse.core.internal.resources.Project.internalBuild(Project.java:535) at org.eclipse.core.internal.resources.Project.build(Project.java:112) at org.eclipse.jdt.core.tests.builder.TestingEnvironment.incrementalBuild(TestingEnvironment.java:793) at org.eclipse.jdt.core.tests.builder.BuilderTests.incrementalBuild(BuilderTests.java:416) at org.eclipse.jdt.core.tests.builder.IncrementalTests.testMoveSecondaryType(IncrementalTests.java:389) at junit.framework.TestCase.runTest(TestCase.java:176) at junit.framework.TestCase.runBare(TestCase.java:141) at junit.framework.TestResult$1.protect(TestResult.java:122) at junit.framework.TestResult.runProtected(TestResult.java:142) at junit.framework.TestResult.run(TestResult.java:125) at junit.framework.TestCase.run(TestCase.java:129) at junit.framework.TestSuite.runTest(TestSuite.java:252) at junit.framework.TestSuite.run(TestSuite.java:247) at junit.framework.TestSuite.runTest(TestSuite.java:252) at junit.framework.TestSuite.run(TestSuite.java:247) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:692) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:319) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32) at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608) at org.eclipse.equinox.launcher.Main.run(Main.java:1515) at org.eclipse.equinox.launcher.Main.main(Main.java:1488) at org.eclipse.core.launcher.Main.main(Main.java:34) T1 is the main thread }}} Looks like JavaModelManager.java#L1033 should have accessed this field by calling JavaProjectElementInfo.getProjectCache. Perhaps JavaProjectElementInfo.projectCache should be made private to eliminate such problem?