Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 475427

Summary:	[compare] No syntax highlighting when IDocument is passed in as input
Product:	[Eclipse Project] Platform	Reporter:	Pascal Rapicault <pascal>
Component:	Team	Assignee:	Pascal Rapicault <pascal>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel, lmcbout, markus.kell.r
Version:	4.5
Target Milestone:	4.6 M3
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/54170 https://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=e1ecbb6bdbe5d9d8d58d9eaaa16a79d609a6b30c
Whiteboard:
Bug Depends on:
Bug Blocks:	477515

Description Pascal Rapicault

2015-08-19 17:37:59 EDT

When an IDocument is passed in as input of a compare editor, the syntax coloring is not applied. This is because the partitioner provided by the textMergeViewer is not associated with the document.

Comment 1 Eclipse Genie

2015-08-19 18:03:42 EDT

New Gerrit change created: https://git.eclipse.org/r/54170

Comment 2 Pascal Rapicault

2015-08-19 18:05:37 EDT

Could you also consider this for inclusion in Mars SR1?

Comment 3 Jacques Bouthillier

2015-09-16 14:20:55 EDT

Is-there a date when we can expect this functionality, I am also looking for it to be able to navigate from the compare editor
Thanks

Comment 4 Eclipse Genie

2015-09-28 04:43:19 EDT

Gerrit change https://git.eclipse.org/r/54170 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=e1ecbb6bdbe5d9d8d58d9eaaa16a79d609a6b30c

Comment 5 Dani Megert

2015-09-28 04:47:16 EDT

(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/54170 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=e1ecbb6bdbe5d9d8d58d9eaaa16a79d609a6b30c
> 

Thanks Pasacal.

I can't think of steps that would allow to reproduce this directly in the SDK. Pascal, let me know if I'm wrong.

Comment 6 Pascal Rapicault

2015-09-29 13:37:42 EDT

Thanks for releasing this!
The "easiest" way to confirm this is working is to install Egerrit from the http://download.eclipse.org/egerrit/updates/integration update site.
Once installed, open the EGerrit view (may also be renamed to Gerrit Dashboard) and from there open a review and compare files.
With your patch released you will get syntax highlighting in the compare editor, without it there won't be.