Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 475298

Summary:	Eclipse setup results in errors
Product:	[ECD] Orion	Reporter:	Andrew Audibert <aaudibert>
Component:	Node	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	major
Priority:	P3
Version:	10.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Andrew Audibert

2015-08-18 16:11:18 EDT

Following https://wiki.eclipse.org/Orion/Getting_the_source results in Eclipse errors because (1) Eclipse doesn't support ECMAScript 4+[1] and (2) the recent nodegit commit inside orionode[2] added functionality which is legal in ECMAScript 5, but not ECMAScript 3, specifically using keywords as method names, e.g. 'git.Reset.default(repo, commit, req.body.Path)'.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=223131
[2] https://github.com/eclipse/orion.client/commit/6637e63cc5a4800146cb585fcbefaf4dd2cf18f5

Comment 1 Mark Macdonald

2016-02-27 13:16:18 EST

Could not reproduce -- when loading the Orion repo into the Eclipse SDK, I don't see any error markers on our .js files. I checked the project settings, and they've been configured to make Eclipse's ancient JavaScript validator skip over the problematic code.

Opening an individual file will still show errors in the ruler, but I don't think we can control that.

Comment 2 Mark Macdonald

2016-02-27 13:18:56 EST

(In reply to Mark Macdonald from comment #1)
> Could not reproduce -- when loading the Orion repo into the Eclipse SDK, I
> don't see any error markers on our .js files.

By this I mean, I don't see any red X's on our code in Eclipse's Problems view. I think this is the best we can hope to achieve.